Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system tests for mac #2339

Merged
merged 25 commits into from
Nov 1, 2024
Merged

Fix system tests for mac #2339

merged 25 commits into from
Nov 1, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented Oct 31, 2024

What It Does

Fixes various system test issues to allow the tests to run better on high performance Mac computers and alternate systems.
This includes:

  • Skipping tests that rely on CIM for job cancellation
  • Appending missing shebang lines
  • Making shell scripts user executable
  • Fixing DSN name too long errors
  • Adding sleeps to scripts that require more time to pass between commands
  • Fixing incorrect logic in shell scripts that used until
  • Using commands that are intercompatible with MacOS (due to grep -P not existing on Mac)
  • Fixing Logs handler incorrectly using client time when no time is specified
  • Fixing an HTTP 1.1 socket reuse error with Node 20 and above
  • Fixing the wrong port tests to also handle an ETIMEDOUT error due to firewalls dropping traffic instead of refusing it.

How to Test

Review Checklist
I certify that I have:

Additional Comments

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
…r-mac

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.12%. Comparing base (715242f) to head (dbe3e4a).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
...perative/src/rest/src/client/AbstractRestClient.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2339      +/-   ##
==========================================
- Coverage   91.12%   91.12%   -0.01%     
==========================================
  Files         636      636              
  Lines       18000    18007       +7     
  Branches     3862     3865       +3     
==========================================
+ Hits        16403    16408       +5     
- Misses       1596     1598       +2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
77.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @awharn for testing the CLI on more environments and finding and fixing a few bugs along the way! 😋

@awharn awharn merged commit 952c1ac into master Nov 1, 2024
17 of 19 checks passed
@awharn awharn deleted the fix-system-tests-for-mac branch November 1, 2024 16:51
@awharn awharn added the release-patch Indicates a patch to existing code has been applied label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Release succeeded for the master branch. 🎉

The following packages have been published:

  • npm: @zowe/imperative@8.6.1
  • npm: @zowe/cli-test-utils@8.6.1
  • npm: @zowe/core-for-zowe-sdk@8.6.1
  • npm: @zowe/zos-uss-for-zowe-sdk@8.6.1
  • npm: @zowe/provisioning-for-zowe-sdk@8.6.1
  • npm: @zowe/zos-console-for-zowe-sdk@8.6.1
  • npm: @zowe/zos-files-for-zowe-sdk@8.6.1
  • npm: @zowe/zos-logs-for-zowe-sdk@8.6.1
  • npm: @zowe/zosmf-for-zowe-sdk@8.6.1
  • npm: @zowe/zos-workflows-for-zowe-sdk@8.6.1
  • npm: @zowe/zos-jobs-for-zowe-sdk@8.6.1
  • npm: @zowe/zos-tso-for-zowe-sdk@8.6.1
  • npm: @zowe/cli@8.6.1

Powered by Octorelease 🚀

@t1m0thyj t1m0thyj linked an issue Nov 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

zowe zos-logs list logs command assumes time is now from Client
4 participants