Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added method to validate the ssh connection #2340

Merged
merged 9 commits into from
Nov 5, 2024
Merged

Conversation

zFernand0
Copy link
Member

What It Does

  • Implements an SSH connection validation method
  • Remove extra $ from the output of ssh commands at the sdk level

How to Test

  • Running zowe uss issue ssh "ls /"should display all folders/files with proper alignment

Review Checklist
I certify that I have:

Additional Comments

Related to:

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.13%. Comparing base (b6e8882) to head (deea16f).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2340    +/-   ##
========================================
  Coverage   91.13%   91.13%            
========================================
  Files         636      636            
  Lines       18002    18011     +9     
  Branches     3864     3759   -105     
========================================
+ Hits        16406    16415     +9     
  Misses       1595     1595            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
@zFernand0 zFernand0 requested a review from awharn November 2, 2024 20:17
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Fernando!

Copy link

sonarcloud bot commented Nov 4, 2024

@zFernand0 zFernand0 merged commit c0f2fc0 into master Nov 5, 2024
19 checks passed
@zFernand0 zFernand0 deleted the ze/iTerm branch November 5, 2024 13:05
@zFernand0 zFernand0 added the release-current Indicates that there is no new functionality being delivered label Nov 5, 2024
@zFernand0
Copy link
Member Author

This should be on public NPM after this workflow is done:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants