fixed start tso app and send tso app output formatting #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2347 +/- ##
=======================================
Coverage 91.15% 91.16%
=======================================
Files 636 636
Lines 18029 18034 +5
Branches 3767 3768 +1
=======================================
+ Hits 16434 16440 +6
+ Misses 1594 1593 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
jace-roell
requested review from
t1m0thyj,
gejohnston,
zFernand0,
awharn,
traeok,
anaxceron,
ATorrise and
adam-wolfe
zFernand0
approved these changes
Nov 5, 2024
traeok
reviewed
Nov 5, 2024
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
awharn
previously requested changes
Nov 6, 2024
…e properly passed to subsequent calls Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
anaxceron
reviewed
Nov 6, 2024
anaxceron
reviewed
Nov 6, 2024
packages/cli/CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| All notable changes to the Zowe CLI package will be documented in this file. | |||
|
|
|||
| ## Recent Changes | |||
|
|
|||
| - BugFix: Improved output formatting for `zowe zos-tso start app` and `zowe zos-tso send app` by parsing and displaying relevant data rather than the entire JSON response [#2347](https://github.com/zowe/zowe-cli/pull/2347) | |||
There was a problem hiding this comment.
- Can we say that these are commands? Like: "Improved output formatting for the AAA and BBB commands by ... "
- Sentence should end w/ a period.
|
traeok
approved these changes
Nov 6, 2024
zFernand0
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
sorry for being picky, but should we also have a system test for the non---rfj approach?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Improved output formatting for
zowe zos-tso start appandzowe zos-tso send appReview Checklist
I certify that I have:
Additional Comments