[v3] Dir to uss encoding flag #2350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2350 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 636 636
Lines 18029 18029
Branches 3767 3767
=======================================
Hits 16434 16434
Misses 1594 1594
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
jace-roell
requested review from
t1m0thyj,
gejohnston,
zFernand0,
awharn,
traeok,
anaxceron and
ATorrise
t1m0thyj
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
LGTM, thanks @jace-roell for the quick fix and for adding a system test!
traeok
approved these changes
Nov 5, 2024
anaxceron
reviewed
Nov 6, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
BugFix: Added support for
--encodingflag tozowe upload dir-to-ussto allow for encoding uploaded directories for command group consitencyReview Checklist
I certify that I have: