Fix system tests 2 #2352
Open
Fix system tests 2 #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
…e directory exists due to race condition Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
…sing modifyVersion 2.0 Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
awharn
requested review from
t1m0thyj,
gejohnston,
zFernand0,
traeok,
anaxceron,
jace-roell and
ATorrise
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2352 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 636 636
Lines 18029 18018 -11
Branches 3767 3764 -3
=======================================
- Hits 16434 16424 -10
+ Misses 1594 1593 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
… tests. Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
t1m0thyj
approved these changes
Nov 5, 2024
| @@ -61,6 +61,7 @@ export function runCliScript(scriptPath: string, testEnvironment: ITestEnvironme | |||
| env: childEnv, | |||
| encoding: "buffer" | |||
| }); | |||
| // eslint-disable-next-line @typescript-eslint/no-magic-numbers | |||
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
traeok
approved these changes
Nov 5, 2024
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
IO.createDirSynclogic to do a recursive create, and not throw an error if a race condition creates a directory after theexistsSynccheck, but before themkdircall.modifyVersionwasn't specified, even though it was available.How to Test
Review Checklist
I certify that I have:
Additional Comments