[v2] Fix for extension failure with refresh Zowe Explorer command #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.18.1 #3107 +/- ##
=================================================
Coverage ? 93.32%
=================================================
Files ? 105
Lines ? 11077
Branches ? 2421
=================================================
Hits ? 10338
Misses ? 738
Partials ? 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
|
📅 Suggested merge-by date: 9/24/2024 |
JillieBeanSim
requested review from
zFernand0,
awharn,
SanthoshiBoyina1 and
likhithanimma1
Fix: Add missing workflow permissions (main)
15 tasks
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Update function-bind dep for technical currency
Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) from 1.8.0 to 1.9.0. - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v1.8.0...v1.9.0) --- updated-dependencies: - dependency-name: path-to-regexp dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…gexp-1.9.0 chore(deps): Bump path-to-regexp from 1.8.0 to 1.9.0
|
t1m0thyj
approved these changes
Sep 17, 2024
traeok
approved these changes
Sep 17, 2024
zFernand0
approved these changes
Sep 17, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixing command for v2 as to not break ZE when used.
Also ports #3102 to v2.18.1 release branch
Proposal for v3:
With the introduction of the Event management and removal of all instance of Zowe Explorer using the zowe.extRefresh command I propose possible removal of command from command palette and suggest users use the new command from VS Code
Extensions: Refreshin v3.Release Notes
Milestone: 2.18.1
Changelog: Fix issue where the Zowe Explorer VS Code command
Refresh Zowe Explorerfailed catastrophically. #3100Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublishpnpm --filter vscode-extension-for-zowe vscode:prepublishCode coverage
Deployment
nextFurther comments