-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v3): Not including extenders in Team config during creation #3133
Conversation
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
📅 Suggested merge-by date: 10/4/2024 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3133 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 113 113
Lines 11658 11658
Branches 2587 2592 +5
=======================================
Hits 10796 10796
Misses 860 860
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Likhitha, this looks great and the fix makes sense to me. Thanks for looking into this!
I'm wondering if we'll want to add a unit test to make sure that the extender types are being passed in to imperative.ConfigBuilder.build
? This way we can verify that Imperative receives all the type configurations when building the config.
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Quality Gate passedIssues Measures |
Added unit test @traeok :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the FTP extension and the config/schema includes the extender types as expected. Thanks Likhitha for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @likhithanimma1
Proposed changes
Solves #3122
Fix bug regarding extender profiles not being added to the config file during creation.
Release Notes
Milestone:
Changelog: Fix issue with extender profiles not being included in fresh team configuration file. [#3122]
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments