Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v3): Not including extenders in Team config during creation #3133

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

likhithanimma1
Copy link
Contributor

Proposed changes

Solves #3122
Fix bug regarding extender profiles not being added to the config file during creation.

Release Notes

Milestone:

Changelog: Fix issue with extender profiles not being included in fresh team configuration file. [#3122]

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Copy link

📅 Suggested merge-by date: 10/4/2024

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (96bc1ba) to head (5b08e52).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3133   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files         113      113           
  Lines       11658    11658           
  Branches     2587     2592    +5     
=======================================
  Hits        10796    10796           
  Misses        860      860           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Likhitha, this looks great and the fix makes sense to me. Thanks for looking into this!
I'm wondering if we'll want to add a unit test to make sure that the extender types are being passed in to imperative.ConfigBuilder.build? This way we can verify that Imperative receives all the type configurations when building the config.

Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Signed-off-by: likhithanimma1 <142219673+likhithanimma1@users.noreply.github.com>
Copy link

sonarcloud bot commented Sep 22, 2024

@likhithanimma1
Copy link
Contributor Author

Hi Likhitha, this looks great and the fix makes sense to me. Thanks for looking into this! I'm wondering if we'll want to add a unit test to make sure that the extender types are being passed in to imperative.ConfigBuilder.build? This way we can verify that Imperative receives all the type configurations when building the config.

Added unit test @traeok :)

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the FTP extension and the config/schema includes the extender types as expected. Thanks Likhitha for the fix!

@JillieBeanSim JillieBeanSim mentioned this pull request Sep 23, 2024
15 tasks
Copy link
Contributor

@adam-wolfe adam-wolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @likhithanimma1

@JillieBeanSim JillieBeanSim merged commit d464418 into main Sep 23, 2024
22 checks passed
@JillieBeanSim JillieBeanSim deleted the Add-extender-profiles branch September 23, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants