Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: improved visibility of text and buttons #1367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aitchessbee
Copy link
Collaborator

@Aitchessbee Aitchessbee commented Apr 23, 2024

What's this PR do?
Improves text and button visibility in settings page as reported in #1357

Screenshots?
Old:
image

New:
image

You have tested this PR on:

  • Windows
  • Linux/Ubuntu
  • macOS

@timabbott
Copy link
Member

Can you present before/after screenshots? Also, I'm not sure which component is the settings_description part.

@Aitchessbee
Copy link
Collaborator Author

Update the description with old and new images... settings_description is a class given to the text in each row. It was already present in the code but wasn't used in css.

@timabbott
Copy link
Member

OK. Text definitely feels a lot better. The dark grey slider background might be overdoing it a bit; is there somewhere a bit in between worth trying?

@alya
Copy link
Collaborator

alya commented Apr 30, 2024

Maybe, but overall this is a definite improvement.

@Axshatt
Copy link

Axshatt commented Jul 9, 2024

OK. Text definitely feels a lot better. The dark grey slider background might be overdoing it a bit; is there somewhere a bit in between worth trying?

I think the tab headings should also be in dark colour as it will be a good user experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants