macos_icon: Fix skewed logo for Spotlight/Finder

[pournaki]

macOS icons are skewed for sizes 16x16, 32x32, 48x48 (see issue #1316 ).

---

What's this PR do?
As previously mentioned in Issue #1316, the app icon in macOS looks skewed in Spotlight, Finder. This PR fixes this look.

Any background context you want to provide?
I created a new icon.icns based on the icons in build/icons using iconutil -c icns.

Screenshots
Before:

After:

You have tested this PR on:

• Windows
• Linux/Ubuntu
• macOS (14.6.1)

[alya]

Thanks for the fix! Could you please update your commit message to match the commit style guidelines?

[pournaki]

Sure, does it comply now?

[alya]

@andersk are you up for reviewing this one?

[pournaki]

I made a mistake building the new logo. I took the files from build/icons, but they are missing a crucial margin. Without it, the logo looks too big in the app switcher. I am attaching a screenshot that compares a logo file extracted from icon.icns (left) to the same size one from build/icons (right).

I have created a new icon.icns with the correct margins by resizing the 512px logo to the faulty sizes using

$ sips -Z <SIZE> icon_512x512.png --out icon_<SIZE>x<SIZE>.png

Is there a way to update this pull request with the new file? Or should I close it and make a new one?

[pournaki]

There is still a (probably) unwanted faint white border around the icon, visible in the Finder (pic1) and Spotlight (pic2). I don't think this is an artifact of the resizing operation.

This line does not appear in the app switcher.

[alya]

Yes, you can push to this PR. https://zulip.readthedocs.io/en/latest/git/using.html might help.