Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visual art: Draw a little monsters avatar set #477

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

anotimpp90c2c7
Copy link

@anotimpp90c2c7 anotimpp90c2c7 commented Jan 14, 2018

boy_1
boy_1_50x50
boy_2
boy_2_50x50
boy_3
boy_3_50x50
boy_4
boy_4_50x50
girl_1
girl_1_50x50
girl_2
girl_2_50x50
girl_3
girl_3_50x50

@eeshangarg
Copy link
Member

@anotimpp90c2c7: Your avatars are great! But there are a couple of issues with your pull request:

  • They are in the wrong folder. They need to be in draw-avatars/anotimpp90c2c7/.
  • Also, you should not have any spaces in the names of the image files. You may use underscores _ or dashes - instead.
  • This PR is only supposed to have 1 commit, not two. And the commit messages are wrong. There needs to be only one commit with the message `visual art: Add a monster-themed avatar set.

I would recommend closely following the Task Type A instructions here and making a PR again! :) If you need any help with Git, just ask on chat.zulip.org! Thanks! :)

@anotimpp90c2c7 anotimpp90c2c7 changed the title anotimpp90c2c7 visual art: Draw a little monsters avatar set Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants