-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port current version of RSSExpandedReader to javascript #630
Conversation
TODO:
|
5dbc695
to
08500d5
Compare
Based on zxing commit 2dfb2054af1e1872ac5354e6d8218931fb88e021.
Happens specifically when the source and destination are the same: System.arraycopy(counters, 0, counters, 1, counters.length - 1)
08500d5
to
e115df4
Compare
Another batch of changes. Can rebase later. (RSSExpandedReader still can't read anything correctly.)
|
Was missing one integer division and accidentally swapped a condition during minor refactoring. Anyway, it works. There are still 2 images failing with and without try harder in Not rebasing/squashing in case it makes a review easier. It probably won't. Edit: As evidenced by the edits, I did end up looking into the failing tests. Both images contain barcodes oriented vertically (or in other words, rotated 90°). I believe rotating the images by 90° should be handled by try harder - not sure why it's not happening. Edit: |
Some tests are still failing |
I assume you're talking about the ones mentioned here. Those try to read barcodes laid out vertically, and so need |
Based on zxing commit 2dfb2054af1e1872ac5354e6d8218931fb88e021.
Finished porting all the code. Incorporated the following fixes: zxing/zxing#1680 zxing/zxing#1692 zxing/zxing#1693 (By manually comparing the existing javascript implementation with the java code).
Didn't attempt running it yet, but all the remaining Java code got ported, including some logic which depended on the values being integers.
Related: #80