Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme added, Gruvbox and Talks "file" link icon #402

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kkYrusobad
Copy link

New theme support for Hugo Zzo-theme, added to Demo also.
all theme colours are taken from official theme maker i.e : morhetz/gruvbox

@zzossig
Copy link
Owner

zzossig commented Apr 22, 2021

Thank you for your effort. This is a very good color scheme.
One thing I worried about is that the CSS file size is getting heavier when we add more themes.
So, I want to find a fundamental solution one of which is a user select themes only needed and exclude others.
After that, I can include the theme!
Thanks again!

@kkYrusobad
Copy link
Author

We can side-load selected themes by the user in the config file. Base css (theme) file remains the same but, the root of blog only contains themes that the user selects by piping in snippets of the larger css file.

@kkYrusobad kkYrusobad changed the title Theme added, Gruvbox Theme added, Gruvbox and Talks "file" link icon Jun 27, 2021
@kkYrusobad
Copy link
Author

kkYrusobad commented Jul 5, 2021

Can you explain a bit more, for demo you can see my site at here.
Edit : did you update your params.toml?

@mrfoxie
Copy link

mrfoxie commented Jul 6, 2021

Can you explain a bit more, for demo you can see my site at here.
Edit : did you update your params.toml?

yes I added there also but when I change the theme then it doesn't work

@kkYrusobad
Copy link
Author

There must be a css linking error, Please recheck all calls and descriptions of theme gruvbox.
Also, did you check the demo? I am using my build for it. It is working fine here.

@mrfoxie
Copy link

mrfoxie commented Jul 7, 2021

There must be a css linking error, Please recheck all calls and descriptions of theme gruvbox.
Also, did you check the demo? I am using my build for it. It is working fine here.

yes I saw your demo and tried like that but it didn't work and didn't get any kind of error site

@kkYrusobad
Copy link
Author

Thank you for pointing out this, there are some inconsistencies in theme .scss files which I'll try to resolve as soon as possible. For the time being consider including a self declaration block for your blogger theme in: mistrysiddh/themes/zzo/assets/sass/themes/_bloggercode.scss

Consider looking at any other .scss for understanding the skeleton for the file. Furthermore test the pull request.

@mrfoxie
Copy link

mrfoxie commented Jul 8, 2021

Thank you for pointing out this, there are some inconsistencies in theme .scss files which I'll try to resolve as soon as possible. For the time being consider including a self declaration block for your blogger theme in: mistrysiddh/themes/zzo/assets/sass/themes/_bloggercode.scss

Consider looking at any other .scss for understanding the skeleton for the file. Furthermore test the pull request.

I merged your pull request but still the same button is not working whereas for other themes it's working fine

@kkYrusobad
Copy link
Author

I think I have it working for your instance, I'll pull in bit but before that let me confirm one thing that this is you theme blogger? right?

blogger

I think you are developing it right now, also I saw the .scss file for this and rendered colors are correct?
Do let me know if this is what you want I'll pull after that. Cheers!

@mrfoxie
Copy link

mrfoxie commented Jul 9, 2021

I think I have it working for your instance, I'll pull in bit but before that let me confirm one thing that this is you theme blogger? right?

blogger

I think you are developing it right now, also I saw the .scss file for this and rendered colors are correct?
Do let me know if this is what you want I'll pull after that. Cheers!

yes I'm developing the theme for more attractive but the option is not working or maybe broken or something else

@kkYrusobad
Copy link
Author

Please review the pull request and see whether your theme is working now or not.

@mrfoxie
Copy link

mrfoxie commented Jul 12, 2021

Please review the pull request and see whether your theme is working now or not.

I tested the theme which I created which is that it doesn't excite it properly and just show without style

@kkYrusobad
Copy link
Author

Gruvbox code syntax highlighting added for theme "gruv"

@mrfoxie
Copy link

mrfoxie commented Nov 29, 2021

Gruvbox code syntax highlighting added for theme "gruv"

after seeing all the commits you have been made it working properly now to still there are some changes been there left for the final touch up

@kkYrusobad
Copy link
Author

Yes, in no way this theme is polished. Code blocks and syntax highlighting are subpar at best. For example, syntax highlighting for bash doesn't work at all and this isn't limited to bash only, other languages suffer the same problem.
Things are inconsistent as of now. I am not working actively on this but I do come back regularly to improve certain aspects of gruv.

@mrfoxie
Copy link

mrfoxie commented Nov 30, 2021

Yes, in no way this theme is polished. Code blocks and syntax highlighting are subpar at best. For example, syntax highlighting for bash doesn't work at all and this isn't limited to bash only, other languages suffer the same problem.
Things are inconsistent as of now. I am not working actively on this but I do come back regularly to improve certain aspects of gruv.

i still can't believe that I made changes and added new theme but not working at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants