Declare and Define Text Domain and Domain Path #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declare and define Text Domain and Domain Path, add missing Text Domain which is the same as plugin's slug.
|
Hope you implement the modified code to the next version so that this plugin becomes fully localizable and displays localized UI correctly. |
Line 116.
zzxiang
reviewed
Aug 3, 2019
| @@ -55,18 +58,16 @@ function init_emwi() { | |||
| add_filter( 'get_attached_file', function( $file, $attachment_id ) { | |||
| if ( empty( $file ) ) { | |||
| $post = get_post( $attachment_id ); | |||
| if ( get_post_type( $post ) == 'attachment' ) { | |||
There was a problem hiding this comment.
The if check for post type is added with another pull request to fix a bug. Does the if check cause other problems? If so maybe we should consider other solutions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declare and define Text Domain and Domain Path, add missing Text Domain which is the same as plugin's slug.