This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
chore: set up java 21 in unit tests #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeWang1127
commented
Oct 18, 2023
| @@ -3,6 +3,8 @@ | |||
| <Match> | |||
| <Or> | |||
| <Bug pattern="DM_STRING_CTOR"/> | |||
| <Bug pattern="EI_EXPOSE_REP"/> | |||
| <Bug pattern="EI_EXPOSE_REP2"/> | |||
There was a problem hiding this comment.
Exclude EI_EXPOSE_REP and EI_EXPOSE_REP2. We can address them in dedicated PR.
[ERROR] Medium: new com.google.cloud.tools.maven.cloudsdk.CloudSdkAppEngineFactory(CloudSdkMojo) may expose internal representation by storing an externally mutable object into CloudSdkAppEngineFactory.mojo [com.google.cloud.tools.maven.cloudsdk.CloudSdkAppEngineFactory] At CloudSdkAppEngineFactory.java:[line 56] EI_EXPOSE_REP2
[ERROR] Medium: com.google.cloud.tools.maven.cloudsdk.CloudSdkMojo.getMavenProject() may expose internal representation by returning CloudSdkMojo.mavenProject [com.google.cloud.tools.maven.cloudsdk.CloudSdkMojo] At CloudSdkMojo.java:[line 125] EI_EXPOSE_REP
[ERROR] Medium: com.google.cloud.tools.maven.cloudsdk.CloudSdkMojo.getMavenSession() may expose internal representation by returning CloudSdkMojo.mavenSession [com.google.cloud.tools.maven.cloudsdk.CloudSdkMojo] At CloudSdkMojo.java:[line 129] EI_EXPOSE_REP
[ERROR] Medium: com.google.cloud.tools.maven.run.AbstractRunMojo.getAdditionalArguments() may expose internal representation by returning AbstractRunMojo.additionalArguments [com.google.cloud.tools.maven.run.AbstractRunMojo] At AbstractRunMojo.java:[line 119] EI_EXPOSE_REP
[ERROR] Medium: com.google.cloud.tools.maven.run.AbstractRunMojo.getEnvironment() may expose internal representation by returning AbstractRunMojo.environment [com.google.cloud.tools.maven.run.AbstractRunMojo] At AbstractRunMojo.java:[line 115] EI_EXPOSE_REP
[ERROR] Medium: com.google.cloud.tools.maven.run.AbstractRunMojo.getJvmFlags() may expose internal representation by returning AbstractRunMojo.jvmFlags [com.google.cloud.tools.maven.run.AbstractRunMojo] At AbstractRunMojo.java:[line 103] EI_EXPOSE_REP
There was a problem hiding this comment.
I also feel these are inevitable for these getters.
JoeWang1127
changed the title
suztomo
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #492