Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

chore: set up java 21 in unit tests #498

Merged
merged 1 commit into from
Oct 19, 2023
+4 −2
Merged

chore: set up java 21 in unit tests #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [8, 11, 17]
java: [8, 11, 17, 21]
env:
CLOUDSDK_CORE_DISABLE_USAGE_REPORTING: true
CLOUDSDK_CORE_DISABLE_PROMPTS: true
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>4.2.3</version>
<version>4.7.3.5</version>
<configuration>
<excludeFilterFile>spotbugs-exclude.xml</excludeFilterFile>
</configuration>
Expand Down
2 changes: 2 additions & 0 deletions spotbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
<Match>
<Or>
<Bug pattern="DM_STRING_CTOR"/>
<Bug pattern="EI_EXPOSE_REP"/>
<Bug pattern="EI_EXPOSE_REP2"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclude EI_EXPOSE_REP and EI_EXPOSE_REP2. We can address them in dedicated PR.

[ERROR] Medium: new com.google.cloud.tools.maven.cloudsdk.CloudSdkAppEngineFactory(CloudSdkMojo) may expose internal representation by storing an externally mutable object into CloudSdkAppEngineFactory.mojo [com.google.cloud.tools.maven.cloudsdk.CloudSdkAppEngineFactory] At CloudSdkAppEngineFactory.java:[line 56] EI_EXPOSE_REP2
[ERROR] Medium: com.google.cloud.tools.maven.cloudsdk.CloudSdkMojo.getMavenProject() may expose internal representation by returning CloudSdkMojo.mavenProject [com.google.cloud.tools.maven.cloudsdk.CloudSdkMojo] At CloudSdkMojo.java:[line 125] EI_EXPOSE_REP
[ERROR] Medium: com.google.cloud.tools.maven.cloudsdk.CloudSdkMojo.getMavenSession() may expose internal representation by returning CloudSdkMojo.mavenSession [com.google.cloud.tools.maven.cloudsdk.CloudSdkMojo] At CloudSdkMojo.java:[line 129] EI_EXPOSE_REP
[ERROR] Medium: com.google.cloud.tools.maven.run.AbstractRunMojo.getAdditionalArguments() may expose internal representation by returning AbstractRunMojo.additionalArguments [com.google.cloud.tools.maven.run.AbstractRunMojo] At AbstractRunMojo.java:[line 119] EI_EXPOSE_REP
[ERROR] Medium: com.google.cloud.tools.maven.run.AbstractRunMojo.getEnvironment() may expose internal representation by returning AbstractRunMojo.environment [com.google.cloud.tools.maven.run.AbstractRunMojo] At AbstractRunMojo.java:[line 115] EI_EXPOSE_REP
[ERROR] Medium: com.google.cloud.tools.maven.run.AbstractRunMojo.getJvmFlags() may expose internal representation by returning AbstractRunMojo.jvmFlags [com.google.cloud.tools.maven.run.AbstractRunMojo] At AbstractRunMojo.java:[line 103] EI_EXPOSE_REP

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also feel these are inevitable for these getters.

</Or>
</Match>
</FindBugsFilter>
Loading