Reversing #177 & additional tests #182
Merged
+248
−116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reversing #177.
Implemented additional tests to try and catch the reported behaviour (see discussion).
What
It was reported that
changed
is not properly triggered in subscription when an array property in a child publication is being updated. Tests were added to validate whether this is indeed the case. The results so far point tochanged
being triggered without problems under the reported circumstances.Additionally:
Collection.find().fetch().length
instead ofCollection.countDocuments()
).Why
PR #177 proposes a change which may lead to unexpected behaviour. The new tests show that either with, or without this change, the updates are propagated without any visible issues. If the problem persists, the test suite should be expanded with the exact case that reproduces the issue.