Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversing #177 & additional tests #182

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

manueltimita
Copy link
Contributor

@manueltimita manueltimita commented Mar 3, 2024

Reversing #177.
Implemented additional tests to try and catch the reported behaviour (see discussion).

What

It was reported that changed is not properly triggered in subscription when an array property in a child publication is being updated. Tests were added to validate whether this is indeed the case. The results so far point to changed being triggered without problems under the reported circumstances.

Additionally:

  • All tests have been modified to only use the sync minimongo API, for simplicity (e.g. use Collection.find().fetch().length instead of Collection.countDocuments()).
  • README updated with instructions for testing.

Why

PR #177 proposes a change which may lead to unexpected behaviour. The new tests show that either with, or without this change, the updates are propagated without any visible issues. If the problem persists, the test suite should be expanded with the exact case that reproduces the issue.

…es#177

The discussion in Meteor-Community-Packages#177 suggests `changed` is not properly triggered in subscription. Tests were added to validate that this is indeed the case (answer: no). The changes in Meteor-Community-Packages#177 have been reverted. All tests have been modified to only use the sync minimongo API, for simplicity. README updated
@manueltimita manueltimita changed the title Reverting #177 & additional tests Reversing #177 & additional tests Mar 3, 2024
This was referenced Mar 3, 2024
@StorytellerCZ StorytellerCZ requested a review from jankapunkt March 3, 2024 23:42
@StorytellerCZ StorytellerCZ merged commit 1f41d63 into Meteor-Community-Packages:master Mar 4, 2024
1 check passed
@StorytellerCZ
Copy link
Member

Will be released in v1.8.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants