Various improvements #832
Merged
Various improvements #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bakert
commented
Nov 10, 2024
bakert
commented
- Rip out hopefully-unused Vue js
- Update baseline after fix
- Defend against unstarted session
- Now that event and player name are not nullable we can skip some checks
- Move psalm to level 1 (highest) and baseline all current violations
- Stylelint
- Check for null
- Simplify calendar, get rid of magic number
- Clean up cardsets table, add missing set codes, simplify
- Almost entirely clean up formatcp's usage of superglobals
- Clean up event.php a little - we should not assign to superglobals
- Make more props of Event not-null, in line with database
- Initialize recent winners empty so we can safely add to it during construction
- River-style SQL
- Move the standard layout into Page
- River-style SQL
- Make standard layout non-optional in Page constructor
- Add missing migration required to make private not nullable
- Banish all mention of meta formats
- Don't allow format to be uninitialized at any stage in Event lifecycle
- Slightly better way to handle ties in bestEver rating
- Replace one of the last "args" funcs with a component
- Constrain the size of the series logo everywhere it appears
- Move sendEmail to helpers, cope with folks with no email address
- Lint
- Make model and db more in sync about what is nullable
- Use a full name not a cryptic name for format control panel menu
- Death to center tags and clear divs
- Type fixes
I don't *think* this does anything ...
Mainly to appease the static checker.
And some other, similar fixes. This lets us move to another psalm level adding just a few oddities to the baseline.
This will give us max static analysis on new code at the cost of swelling the baseline considerably. We adopted this system with phpstan and it has been helpful so trying it here, too.
Now we just load all events starting two weeks back. Seems better.
Still passing $_POST to updateFormat to avoid passing 21 params but at least we're doing it at the top level now.
Just Home and Profile don't use this but I didn't find a way to crowbar those into it yet so it remains an option not the default.
This way you are forced to choose if your page has the standard layout or not and we tracked down a few pages/templates that needed updating.
They are unused. If we want to revive it later git will remember.
Would it be better still to pick one based on MIN(r.updated) or something?
It was out of control on Series CP.
List out props instead of looping for static analysis.
It should be Cp not CP if we're going to use Cp anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.