Code

Various improvements#832

Code

Merged

bakert merged 29 commits intodevPennyDreadfulMTG/gatherling:devfrom dark-agesPennyDreadfulMTG/gatherling:dark-agesCopy head branch name to clipboardNov 10, 2024

+4,083-1,911

Commits

Commits on Nov 9, 2024

• Rip out hopefully-unused Vue js

  Show description for 086abf7
  bakert

  committed
  086abf7

  Copy full SHA for 086abf7

• Update baseline after fix

  bakert

  committed
  3c088d2

  Copy full SHA for 3c088d2

• Defend against unstarted session

  Show description for 3dea030
  bakert

  committed
  3dea030

  Copy full SHA for 3dea030

• Now that event and player name are not nullable we can skip some checks

  Show description for 94e785c
  bakert

  committed
  94e785c

  Copy full SHA for 94e785c

• Move psalm to level 1 (highest) and baseline all current violations

  Show description for 3670c4e
  bakert

  committed
  3670c4e

  Copy full SHA for 3670c4e

• Stylelint

  bakert

  committed
  1be7688

  Copy full SHA for 1be7688

• Check for null

  bakert

  committed
  6e6fde4

  Copy full SHA for 6e6fde4

• Simplify calendar, get rid of magic number

  Show description for 5e37bcc
  bakert

  committed
  5e37bcc

  Copy full SHA for 5e37bcc

• Clean up cardsets table, add missing set codes, simplify

  bakert

  committed
  d3bec0a

  Copy full SHA for d3bec0a

• Almost entirely clean up formatcp's usage of superglobals

  Show description for f3f4567
  bakert

  committed
  f3f4567

  Copy full SHA for f3f4567

• Clean up event.php a little - we should not assign to superglobals

  bakert

  committed
  32f156b

  Copy full SHA for 32f156b

• Make more props of Event not-null, in line with database

  bakert

  committed
  711ccaf

  Copy full SHA for 711ccaf

• Initialize recent winners empty so we can safely add to it during construction

  bakert

  committed
  aeda487

  Copy full SHA for aeda487

• River-style SQL

  bakert

  committed
  329fa8d

  Copy full SHA for 329fa8d

• Move the standard layout into Page

  Show description for 980bf77
  bakert

  committed
  980bf77

  Copy full SHA for 980bf77

• River-style SQL

  bakert

  committed
  2f4e4f7

  Copy full SHA for 2f4e4f7

• Make standard layout non-optional in Page constructor

  Show description for 60633bc
  bakert

  committed
  60633bc

  Copy full SHA for 60633bc

• Add missing migration required to make private not nullable

  bakert

  committed
  b79e245

  Copy full SHA for b79e245

• Banish all mention of meta formats

  Show description for 5b0e15f
  bakert

  committed
  5b0e15f

  Copy full SHA for 5b0e15f

• Don't allow format to be uninitialized at any stage in Event lifecycle

  bakert

  committed
  bc6ce8a

  Copy full SHA for bc6ce8a

• Slightly better way to handle ties in bestEver rating

  Show description for 5163b71
  bakert

  committed
  5163b71

  Copy full SHA for 5163b71

• Replace one of the last "args" funcs with a component

  bakert

  committed
  675ee0e

  Copy full SHA for 675ee0e

• Constrain the size of the series logo everywhere it appears

  Show description for 19f340c
  bakert

  committed
  19f340c

  Copy full SHA for 19f340c

Commits on Nov 10, 2024

• Move sendEmail to helpers, cope with folks with no email address

  bakert

  committed
  4508c1d

  Copy full SHA for 4508c1d

• Lint

  bakert

  committed
  7d09c31

  Copy full SHA for 7d09c31

• Make model and db more in sync about what is nullable

  Show description for c389a09
  bakert

  committed
  c389a09

  Copy full SHA for c389a09

• Use a full name not a cryptic name for format control panel menu

  Show description for 8f14d4e
  bakert

  committed
  8f14d4e

  Copy full SHA for 8f14d4e

• Death to center tags and clear divs

  bakert

  committed
  4c938d2

  Copy full SHA for 4c938d2

• Type fixes

  bakert

  committed
  f332aba

  Copy full SHA for f332aba