This repository has been archived by the owner on May 1, 2024. It is now read-only.
forked from validatedpatterns/multicluster-devsecops
-
Notifications
You must be signed in to change notification settings - Fork 2
Pattern final fixes #5
Merged
TomerFi
merged 105 commits into
RHEcosystemAppEng:main
from
r2dedios:pattern-final-fixes
Mar 27, 2024
Merged
Pattern final fixes #5
TomerFi
merged 105 commits into
RHEcosystemAppEng:main
from
r2dedios:pattern-final-fixes
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
chore: pattern touchups
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
chore: pattern touchups
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
chore: removed unused manifest
Rdr tuning
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
TomerFi
force-pushed
the
pattern-final-fixes
branch
2 times, most recently
from
March 26, 2024 19:56
2b99b03
to
21c940a
Compare
@r2dedios Documentation is done for now, and linting works. I still need to fix the failing unit tests. We can merge this PR regardless to get the documentation into the main branch. I can fix the tests using a different PR. What do you say? |
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
TomerFi
force-pushed
the
pattern-final-fixes
branch
from
March 26, 2024 21:38
21c940a
to
d91142a
Compare
r2dedios
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.