Fix CI #534
Merged
Fix CI #534
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
fix-ci
branch
2 times, most recently
from
d05f405 to
fc9f1ec
Compare
`ActiveSupport::LoggerThreadSafeLevel` depends on `logger`, but doesn't require it explicitly prior to 7.1. In the real application, the `logger` is likely required by other components so this is not an issue. But for this gem's test setup, we need to require it explicitly.
st0012
commented
Jan 16, 2025
| require "job-iteration" | ||
| require "active_job" |
There was a problem hiding this comment.
active_job is already be required by job-iteration.
| require "job-iteration" | ||
| require "job-iteration/test_helper" | ||
|
|
||
| require "globalid" | ||
| require "sidekiq" | ||
| require "resque" | ||
| require "active_job" |
There was a problem hiding this comment.
active_job is already be required by job-iteration.
| @@ -13,6 +13,7 @@ jobs: | |||
| ports: | |||
| - 6379:6379 | |||
| strategy: | |||
| fail-fast: false | |||
There was a problem hiding this comment.
From my experience maintaining projects with a complicated dependency matrix, it's best not to fail fast on these kinds of builds so we can get a better sense on what's failing.
Mangara
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveSupport::LoggerThreadSafeLeveldepends onlogger, but doesn't require it explicitly prior to 7.1. In the real application, theloggeris likely required by other components so this is not an issue. But for this gem's test setup, we need to require it explicitly.