Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #534

Merged
merged 3 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
ports:
- 6379:6379
strategy:
fail-fast: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my experience maintaining projects with a complicated dependency matrix, it's best not to fail fast on these kinds of builds so we can get a better sense on what's failing.

matrix:
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
rails: ["5.2", "6.0", "6.1", "7.0", "7.1", "7.2", "edge"]
Expand Down
2 changes: 2 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,5 @@ gem "csv" # required for Ruby 3.4+

# for unit testing optional sorbet support
gem "sorbet-runtime"

gem "logger"
2 changes: 2 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ GEM
concurrent-ruby (~> 1.0)
json (2.7.2)
language_server-protocol (3.17.0.3)
logger (1.6.5)
method_source (1.1.0)
minitest (5.24.0)
mocha (2.7.1)
Expand Down Expand Up @@ -118,6 +119,7 @@ DEPENDENCIES
globalid
i18n
job-iteration!
logger
mocha
mysql2!
pry
Expand Down
3 changes: 3 additions & 0 deletions test/integration/interruption_adapters_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ class InterruptionAdaptersTest < ActiveSupport::TestCase
require 'bundler/setup'
# Remove sidekiq, only resque will be left
$LOAD_PATH.delete_if { |p| p =~ /sidekiq/ }
require 'logger'
require 'job-iteration'
JobIteration::InterruptionAdapters.lookup(:resque)
RUBY
Expand All @@ -23,6 +24,7 @@ class InterruptionAdaptersTest < ActiveSupport::TestCase
require 'bundler/setup'
# Remove sidekiq, only resque will be left
$LOAD_PATH.delete_if { |p| p =~ /sidekiq/ }
require 'logger'
require 'job-iteration'
JobIteration::InterruptionAdapters.lookup(:sidekiq)
RUBY
Expand All @@ -35,6 +37,7 @@ class InterruptionAdaptersTest < ActiveSupport::TestCase
test "loads all available interruption adapters" do
ruby = <<~RUBY
require 'bundler/setup'
require 'logger'
require 'job-iteration'

adapters_to_exclude = [:good_job, :solid_queue, :sqs] # These require a Rails app to be loaded
Expand Down
2 changes: 1 addition & 1 deletion test/support/resque/Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
# $LOAD_PATH.unshift File.dirname(__FILE__) unless $LOAD_PATH.include?(File.dirname(__FILE__))
require "resque/tasks"

require "logger"
require "job-iteration"
require "active_job"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

active_job is already be required by job-iteration.

require "i18n"

require_relative "../jobs"
Expand Down
2 changes: 1 addition & 1 deletion test/test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
$LOAD_PATH.unshift(File.expand_path("../../lib", __FILE__))
require "minitest/autorun"

require "logger"
require "job-iteration"
require "job-iteration/test_helper"

require "globalid"
require "sidekiq"
require "resque"
require "active_job"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

active_job is already be required by job-iteration.

require "active_record"
require "pry"
require "mocha/minitest"
Expand Down
Loading