Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming mapdl.mode to mapdl.connection #2431

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 18, 2023

Because conflict to MAPDL command MODE.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2431 (2c50fdd) into main (32743f0) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2431      +/-   ##
==========================================
- Coverage   81.93%   81.88%   -0.05%     
==========================================
  Files          44       44              
  Lines        8453     8453              
==========================================
- Hits         6926     6922       -4     
- Misses       1527     1531       +4     

@github-actions
Copy link
Contributor

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore
you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

@germa89 germa89 enabled auto-merge (squash) October 19, 2023 14:44
@germa89 germa89 merged commit 3e6b922 into main Oct 19, 2023
25 checks passed
@germa89 germa89 deleted the feat/renaming-mapdl.mode branch October 19, 2023 16:57
@germa89 germa89 mentioned this pull request Feb 1, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants