Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming mapdl.mode to mapdl.connection #2431

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Renaming mapdl.mode to mapdl.connection #2431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a54abbb
Renaming `mapdl.mode` to `mapdl.connection`
germa89 Oct 18, 2023
5dd2f81
Update the image cache
germa89 Oct 19, 2023
2c50fdd
Empty comment to trigger CICD
germa89 Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ansys/mapdl/core/mapdl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,8 @@ def print_com(self, value):
)

@property
def mode(self):
"""Return the type of instance, namely: grpc, corba or console."""
def connection(self):
"""Return the type of connection to the instance, namely: grpc, corba or console."""
return self._mode

@property
Expand Down
Binary file modified tests/.image_cache/plot_incomplete_nodal_selection.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/test_grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ def test__channel_str(mapdl):


def test_mode_corba(mapdl):
assert mapdl.mode == "grpc"
assert mapdl.connection == "grpc"
assert mapdl.is_grpc
assert not mapdl.is_corba
assert not mapdl.is_console
Expand Down
2 changes: 1 addition & 1 deletion tests/test_mapdl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,7 +1578,7 @@ def test_set_list(mapdl, cube_solve):


def test_mode(mapdl):
assert mapdl.mode == "grpc"
assert mapdl.connection == "grpc"
assert mapdl.is_grpc
assert not mapdl.is_corba
assert not mapdl.is_console
Expand Down