Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementing ansys/actions/changelogs and adding release note in documentation #3019

Merged
merged 39 commits into from
Jun 18, 2024

Conversation

clatapie
Copy link
Contributor

Implementing release note in documentation, using ansys/actions/changelogs and ansys/pyansys-geometry#1138.

@clatapie clatapie requested a review from a team as a code owner April 22, 2024 12:24
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added Documentation CI/CD Related with CICD, Github Actions, etc labels Apr 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (7c1eb1e) to head (7ada8b1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3019      +/-   ##
==========================================
- Coverage   86.63%   84.17%   -2.47%     
==========================================
  Files          52       52              
  Lines        9550     9550              
==========================================
- Hits         8274     8039     -235     
- Misses       1276     1511     +235     

@clatapie clatapie marked this pull request as draft April 22, 2024 15:44
.github/release.yml Outdated Show resolved Hide resolved
@germa89 germa89 force-pushed the doc/changelog_rst branch from 21dd02a to 67926bb Compare April 29, 2024 10:23
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@clatapie clatapie requested review from germa89 and PipKat June 13, 2024 16:15
@clatapie clatapie requested a review from RobPasMue June 14, 2024 09:58
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All in order =)

@clatapie clatapie self-assigned this Jun 17, 2024
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some references missing IMHO.

.github/labeler.yml Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@germa89
Copy link
Collaborator

germa89 commented Jun 18, 2024

I realised that dependabot also has a prefix for the commits. You might need to adapt that one too.

prefix: "MAINT"

clatapie and others added 2 commits June 18, 2024 09:43
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@clatapie
Copy link
Contributor Author

I realised that dependabot also has a prefix for the commits. You might need to adapt that one too.

prefix: "MAINT"

Good catch, thank you @germa89.
I modified the dependabot.yml file as follow:

  • for the pip package ecosystem: the prefix used is now build as it concerns external dependencies.
  • for the github-actions package ecosystem: the prefix used is now ci as it concerns CI configuration.

@germa89
Copy link
Collaborator

germa89 commented Jun 18, 2024

Do we have to change dependabot branch names too?

So far the branch names are something like dependabot/github_actions/actions-0bd1363a87 (#3175).

Shall we check how to change those names? or maybe skip that workflow for dependabot PRs?

@clatapie
Copy link
Contributor Author

As the ansys/action accepts dependabot/ as a branch name, there is no need to modify it.
Also, it seems that this name is not configurable.

@clatapie clatapie enabled auto-merge (squash) June 18, 2024 09:12
@clatapie clatapie merged commit 4953669 into main Jun 18, 2024
40 checks passed
@clatapie clatapie deleted the doc/changelog_rst branch June 18, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants