Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotate FunctionMixin methods _ad_mul and _ad_add #3841

Merged
merged 2 commits into from
Oct 29, 2024
Merged

annotate FunctionMixin methods _ad_mul and _ad_add #3841

merged 2 commits into from
Oct 29, 2024

Conversation

JHopeCollins
Copy link
Member

@JHopeCollins JHopeCollins commented Oct 25, 2024 •
edited
Loading

These are not marked no_annotate in the pyadjoint.OverloadedType abstract methods.

@JHopeCollins JHopeCollins self-assigned this Oct 25, 2024
@JHopeCollins
Copy link
Member Author

Even without no_annotations I don't think these add anything to the tape because they are implemented using Function.vector(). Should they be updated to just use existing Function operations?

@connorjward
Copy link
Contributor

Even without no_annotations I don't think these add anything to the tape because they are implemented using Function.vector(). Should they be updated to just use existing Function operations?

Anything with .vector() is deprecated functionality and should ideally get replaced with Firedrake-specific operations. Vector was a shim class for FEniCS compatibility that has now been abandoned.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8078 ran6495 passed1583 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8084 ran7298 passed786 skipped0 failed

connorjward
connorjward approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks reasonable.

@JHopeCollins JHopeCollins merged commit 76d44cf into master Oct 29, 2024
12 checks passed
@JHopeCollins JHopeCollins deleted the JHopeCollins/annotate_function_add_mul branch October 29, 2024 10:35
connorjward pushed a commit that referenced this pull request Nov 25, 2024
@JHopeCollins @connorjward
annotate FunctionMixin methods _ad_mul and _ad_add (#3841)
1e191fb 
* annotate FunctionMixin _ad_mul and _ad_add

* FunctionMixin _ad_mul and _ad_add use Function operations not Vector operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjward connorjward connorjward approved these changes

Assignees

@JHopeCollins JHopeCollins

Labels
bug firedrake-adjoint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JHopeCollins @connorjward