Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotate FunctionMixin methods _ad_mul and _ad_add #3841

Merged
merged 2 commits into from
Oct 29, 2024
Merged

annotate FunctionMixin methods _ad_mul and _ad_add #3841

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ca034f
annotate FunctionMixin _ad_mul and _ad_add
JHopeCollins Oct 25, 2024
4fd0d63
FunctionMixin _ad_mul and _ad_add use Function operations not Vector …
JHopeCollins Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions firedrake/adjoint_utils/function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,6 @@ def _ad_will_add_as_dependency(self):
with checkpoint_init_data():
super()._ad_will_add_as_dependency()

@no_annotations
def _ad_mul(self, other):
from firedrake import Function

Expand All @@ -309,7 +308,6 @@ def _ad_mul(self, other):
r.assign(other * self)
return r

@no_annotations
def _ad_add(self, other):
from firedrake import Function

Expand Down Expand Up @@ -363,16 +361,12 @@ def _ad_dim(self):
return self.function_space().dim()

def _ad_imul(self, other):
vec = self.vector()
vec *= other
self *= other
return self

def _ad_iadd(self, other):
vec = self.vector()
ovec = other.vector()
if ovec.dat == vec.dat:
vec *= 2
else:
vec += ovec
self += other
return self

def _ad_function_space(self, mesh):
return self.ufl_function_space()
Expand Down
Loading