Context map feature #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting take on this one. Does it support multiple "structured arguments" too or only a single map? I don't understand how the formatting of the map for the message itself works – wouldn't that be |
|
Nevermind, I saw only now that |
knittl
reviewed
Feb 9, 2020
| @@ -23,6 +23,7 @@ | |||
| private int maxQueueSize = 100 * 1024 * 1024; | |||
| private Authentication authentication; | |||
| private int maxMessageSize = -1; | |||
| private boolean enableContextMap; | |||
There was a problem hiding this comment.
Your indentation in this MR seems to be off (inconsistent use of tabs and spaces)
| if (arguments == null || arguments.length == 0) return; | ||
| Object lastElement = arguments[arguments.length - 1]; | ||
| if (lastElement instanceof Map) { | ||
| Map<String, Object> indexes = traverseObject(new HashMap<String, Object>(), "context", lastElement); |
There was a problem hiding this comment.
I would suggest to call traverseMap directly here. It took me a bit to figure out why traverseObject is performing instanceof checks again, when lastElement is already guaranteed to be a map here.
cgoIT
added a commit
to cgoIT/logback-elasticsearch-appender
that referenced
this pull request
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by Context Map feature from logstash-logback-encoder for adding event-specific custom fields to message.
Example:
Log line:
log.info("Service started in {} seconds", duration/1000, Collections.singletonMap("duration", duration));
Result:
{
"@timestamp": "2014-06-04T15:26:14.464+02:00",
"message": "Service started in 12 seconds",
"duration": 12368,
}