-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context map feature #65
Open
ntvf
wants to merge
3
commits into
internetitem:master
Choose a base branch
from
ntvf:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
src/main/java/com/internetitem/logback/elasticsearch/util/ContextMapWriter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
package com.internetitem.logback.elasticsearch.util; | ||
|
||
import ch.qos.logback.classic.spi.ILoggingEvent; | ||
import com.fasterxml.jackson.core.JsonGenerator; | ||
|
||
import java.io.IOException; | ||
import java.util.Collection; | ||
import java.util.HashMap; | ||
import java.util.Iterator; | ||
import java.util.Map; | ||
import java.util.Objects; | ||
|
||
public class ContextMapWriter { | ||
|
||
public void writeContextMap(JsonGenerator gen, ILoggingEvent event) throws IOException { | ||
Object[] arguments = event.getArgumentArray(); | ||
if (arguments == null || arguments.length == 0) return; | ||
Object lastElement = arguments[arguments.length - 1]; | ||
if (lastElement instanceof Map) { | ||
Map<String, Object> indexes = traverseObject(new HashMap<String, Object>(), "context", lastElement); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would suggest to call |
||
for (Map.Entry<String, Object> entry : indexes.entrySet()) { | ||
String key = entry.getKey(); | ||
Object value = entry.getValue(); | ||
gen.writeObjectField(key, value); | ||
} | ||
} | ||
} | ||
|
||
static Map<String, Object> traverseObject(Map<String, Object> accumulator, String context, Object object) { | ||
if (object == null) { | ||
return accumulator; | ||
} | ||
if (object instanceof Map) { | ||
traverseMap(accumulator, context, (Map) object); | ||
} else if (object instanceof Collection) { | ||
traverseCollection(accumulator, context, (Collection) object); | ||
} else if (object instanceof Number) { | ||
accumulator.put(context, object); | ||
} else { | ||
accumulator.put(context, Objects.toString(object)); | ||
} | ||
return accumulator; | ||
} | ||
|
||
static Map<String, Object> traverseCollection(Map<String, Object> accumulator, String context, Collection object) { | ||
Iterator iterator = object.iterator(); | ||
int i = 0; | ||
while (iterator.hasNext()) { | ||
Object v = iterator.next(); | ||
traverseObject(accumulator, context + "." + i, v); | ||
i++; | ||
} | ||
return accumulator; | ||
} | ||
|
||
static Map<String, Object> traverseMap(Map<String, Object> accumulator, String context, Map<Object, Object> object) { | ||
for (Map.Entry entry : object.entrySet()) { | ||
traverseObject(accumulator, context + "." + entry.getKey(), entry.getValue()); | ||
} | ||
return accumulator; | ||
} | ||
} |
46 changes: 46 additions & 0 deletions
46
src/test/java/com/internetitem/logback/elasticsearch/ContextMapWriterTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
package com.internetitem.logback.elasticsearch; | ||
|
||
import ch.qos.logback.classic.spi.LoggingEvent; | ||
import com.fasterxml.jackson.core.JsonGenerator; | ||
import com.internetitem.logback.elasticsearch.util.ContextMapWriter; | ||
import org.junit.Before; | ||
import org.junit.Test; | ||
import org.junit.runner.RunWith; | ||
import org.mockito.Mock; | ||
import org.mockito.runners.MockitoJUnitRunner; | ||
|
||
import java.io.IOException; | ||
|
||
import static org.mockito.Mockito.verifyZeroInteractions; | ||
|
||
@RunWith(MockitoJUnitRunner.class) | ||
public class ContextMapWriterTest { | ||
|
||
@Mock | ||
private JsonGenerator jsonGenerator; | ||
|
||
|
||
private ContextMapWriter contextMapWriter; | ||
|
||
@Before | ||
public void setup() throws IOException { | ||
contextMapWriter = new ContextMapWriter(); | ||
} | ||
|
||
@Test | ||
public void should_not_write_if_arguments_null_or_empty() throws IOException { | ||
LoggingEvent event = new LoggingEvent(); | ||
contextMapWriter.writeContextMap(jsonGenerator, event); | ||
event.setArgumentArray(new Object[]{}); | ||
contextMapWriter.writeContextMap(jsonGenerator, event); | ||
verifyZeroInteractions(jsonGenerator); | ||
} | ||
|
||
@Test | ||
public void should_not_write_if_last_element_not_map() throws IOException { | ||
LoggingEvent event = new LoggingEvent(); | ||
event.setArgumentArray(new Object[]{"23", 3243}); | ||
contextMapWriter.writeContextMap(jsonGenerator, event); | ||
verifyZeroInteractions(jsonGenerator); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your indentation in this MR seems to be off (inconsistent use of tabs and spaces)