Doubly periodic MA demo #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
added
documentation
ddundo
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Nice demo! Just two minor comments.
Could you please also update the link to renamed monge_ampere_ring.py demo in the 3D demo? In line 35
movement/demos/monge_ampere_3d.py
Line 35 in b090830
Co-authored-by: Davor Dundovic <33790330+ddundo@users.noreply.github.com>
Good point. Done in ed223ef. |
ddundo
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25.
Linked PR: mesh-adaptation/docs#96.
Introduces a new MA demo that checks things work as expected on a doubly periodic domain.