-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add level-1 readers for the arctic weather satelliter data #2565
Add level-1 readers for the arctic weather satelliter data #2565
Conversation
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
==========================================
+ Coverage 96.01% 96.12% +0.11%
==========================================
Files 380 383 +3
Lines 55445 55577 +132
==========================================
+ Hits 53234 53424 +190
+ Misses 2211 2153 -58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments for now.
…cation and angles Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Pull Request Test Coverage Report for Build 12748975290Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice, many thanks!
So, just a comment/observation. The AWS testdata file delivered August 2023 has the datasets structured a bit odd and different from most other satellite datasets (e.g. the EPS-SG MWS testdata which format it is supposed to follow). Here a phrase communicated to ESA abouth this layout issue: "The ordering of the dimensions is unexpected, e.g. for “aws_toa_brightness_temperature” we have (19, 145, 4991) which is (n_channels, n_fovs, n_scans). But in netCDF the first dimension is always the one that varies the most slowly. For MWS the order is reversed, i.e. (n_scans, n_fovs, n_channels)." This ordering currently has the unfortunate consequence that the optimal radius of influence used for remapping cannot be determined. The method I am preparing a PR for Pyresample on this. Until now one has to provide a reasonable value (say 40000) for When doing this one may be able create an image like the below using code similar to this (I have here skipped the decoration/coast overlay part for simplification):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments inline. I'd like some clarifiactions, but in general LGTM!
I somehow thought we had merged this long ago? Sorry for not coming back to your comments/questions earlier! |
Any news on the new test dataset? |
Co-authored-by: Panu Lahtinen <pnuu+git@iki.fi>
Co-authored-by: Panu Lahtinen <pnuu+git@iki.fi>
…raised in the PR review Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
…:adybbroe/satpy into add-arctic-weather-satelliter-l1b-reader
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the unresolved points, there was some kind of misunderstanding with the datetime imports, fixes suggested. Also the file patterns need some fixing.
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Yeah, don't know what I did, sorry. Now fixed. |
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
satpy/etc/composites/mwr.yaml
Outdated
@@ -0,0 +1,46 @@ | |||
sensor_name: mwr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a microwave instrument right? Do we need to define a "base" sensor type for "microwave" making this sensor_name: microwave/mwr
? Or does this work as-is and we won't worry about a shared set of "microwave" composites? If this isn't microwave, then this should probably be sensor_name: visir/mwr
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. I think it sounds right to have a "microwave" group here. I was, however, not sure how this works. But I try add it now.... Just need to do some system, testing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay I believe.
Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
This PR adds a reader for the ESA Arctic Weather Satellite (AWS) l1b format, as well as the corresponding EUMETSAT AWS Level-1b format. The latter to become the EPS-Sterna level-1b file format.
The ESA AWS file format is not documented anywhere but is netCDF and supposed to follow the EPS-SG MWS level-1b format. See https://www.eumetsat.int/media/44139
Here a draft version of the EPS-Sterna level-1b file format, as od December 2024:
EPS-Sterna Level 1B Product Format Specification (PFS) v1C [Approved].docx
ESA has also developed a level-1c processor, mapping the data for all four channels groups (feed horns) to one of the groups, default is the 183 GHz group. This PR also includes a first reader for this L1c file format. The ESA L1c file format is neither documented, but it is following the L1b format closely.
This PR was started autumn 2023 where the ESA AWS level-1b file format had not matured. Now, the format is supposed to be the final, and we have used first real data processed and delivered to us (SMHI among other partners in the MWS/AWS SAG and EUMETSAT) in November 2024.
AUTHORS.md
if not there already