-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add level-1 readers for the arctic weather satelliter data #2565
Merged
adybbroe
merged 59 commits into
pytroll:main
from
adybbroe:add-arctic-weather-satelliter-l1b-reader
Jan 14, 2025
Merged
Changes from 46 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
dca7640
Merge branch 'main' into add-arctic-weather-satelliter-l1b-reader
a35b1de
First version of the l1b reader for the Arctic Weather Satellite
4d6fee9
Fix longitudes to be bbetween -180 and 180 and other fixes for geo-lo…
5c3a7d3
Add some first basic humidity RGB recipes
8f0d1bf
Start working on tests for aws l1b
mraspaud 7191df1
Finalize aws_l1b refactoring and tests
mraspaud 6b5a97b
Merge branch 'main' into add-arctic-weather-satelliter-l1b-reader
mraspaud e526ff5
Replace single quotes with double quotes
mraspaud f039715
Fix aws yaml file
mraspaud 47821d6
Fix aws reader according to review comments
mraspaud 9e9439a
Merge branch 'main' into add-arctic-weather-satelliter-l1b-reader
95f744e
Merge branch 'main' into add-arctic-weather-satelliter-l1b-reader
dea6a67
Fixed for latest real-data (not yet final format)
70bbc86
Changing the humidity-surface RGB to consider the lowest peaking abso…
a84d874
A first draft fix of the viewing geometry per feed horn
b6f9b99
Merge branch 'main' into add-arctic-weather-satelliter-l1b-reader
b22514c
Merge branch 'main' into add-arctic-weather-satelliter-l1b-reader
da735b3
Merge branch 'main' into add-arctic-weather-satelliter-l1b-reader
c1b2d9d
Add support for reading the EUMETSAT AWS/EPS-Sterna L1b data
b2775eb
Add support for reading ESA AWS L1c
41e7975
Fix the tests
441ee06
Adapt test to latest AWS l1b format
1437cd1
Fix tests and add some basic RGB recipes for AWS
5502cfd
Merge branch 'main' into add-arctic-weather-satelliter-l1b-reader
23fcf3c
Fix for xarray > 2024.09, and leave stand alone datatree
b8b08e4
First version of the l1b reader for the Arctic Weather Satellite
0c28004
Fix the naming - The AWS/EPS-Sterna sensor is named "MWR"
9ec30bc
Refactor tests and fix naming for AWS/EPS-Sterna Radiometer = MWR
3e16010
Merge branch 'main' of https://github.com/pytroll/satpy into add-arct…
bf450fd
Revert back to the old (current) version
8bee181
Bugfix
3badb8d
Bugfix
a6414c9
Refactor and share code between the l1b and l1c readers
a5d472a
Fix tests
55c999e
Refactor and add test coverage for the ESA AWS Level-1c reader
110cd9c
Update satpy/etc/composites/mwr.yaml
adybbroe 7347fb0
Update satpy/tests/reader_tests/conftest.py
adybbroe 1cf434c
Fix file naming and secure composite recipe consistency
1e49dd5
Update satpy/readers/mwr_l1b.py
adybbroe 62c3b36
Remove redundant MWR specific enhancement
7815186
Merge branch 'add-arctic-weather-satelliter-l1b-reader' of github.com…
b2f0e14
Update satpy/etc/readers/eps_sterna_mwr_l1b_nc.yaml
adybbroe 1ef7cc3
Fix spelling
adybbroe afe175b
Update satpy/tests/reader_tests/test_aws1_mwr_l1c.py
adybbroe 3a71be5
Update satpy/readers/mwr_l1c.py
adybbroe 49fb564
Update satpy/tests/reader_tests/test_aws1_mwr_l1c.py
adybbroe ba126cc
Fix sensor name and adjust yaml files accordingly + fix a few issues …
f03f796
Merge branch 'add-arctic-weather-satelliter-l1b-reader' of github.com…
0eb261a
Fix file name pattern
05d952e
Refactor the AWS/EPS-STerna tests
152b45e
Fixed datetime import syntax - use custom practice
4ad6ef4
Remove redundant timedelta import
2b8aecb
Clean up and improve file patterns for AWS/EPS-Sterna
cd21dd2
Fix short/long names and make improvements raised in the review
a703757
Add missing enhancement
a17b8b3
Refactor AWS/EPS-Sterna l1b file fixtures
c7d5fe9
Refactoring tests reusing the l1b file creation part also for level-1c
d4654d1
Fix right processing level in tmp file name
0b9760c
Improvements following review comments.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
sensor_name: mwr | ||
|
||
composites: | ||
mw183_humidity: | ||
standard_name: mw183_humidity | ||
compositor: !!python/name:satpy.composites.GenericCompositor | ||
prerequisites: | ||
- name: '11' | ||
- name: '13' | ||
- name: '15' | ||
|
||
mw183_humidity_surface: | ||
compositor: !!python/name:satpy.composites.RGBCompositor | ||
prerequisites: | ||
- name: '9' | ||
- name: '10' | ||
- name: '12' | ||
standard_name: mw183_humidity_surface | ||
|
||
mw325_humidity_surface: | ||
compositor: !!python/name:satpy.composites.RGBCompositor | ||
prerequisites: | ||
- name: '9' | ||
- name: '10' | ||
- name: '19' | ||
standard_name: mw325_humidity_surface | ||
|
||
mw325_humidity: | ||
compositor: !!python/name:satpy.composites.RGBCompositor | ||
prerequisites: | ||
- name: '16' | ||
- name: '18' | ||
- name: '19' | ||
standard_name: mw325_humidity | ||
|
||
ch1_tbs_colors: | ||
compositor: !!python/name:satpy.composites.SingleBandCompositor | ||
prerequisites: | ||
- name: '1' | ||
standard_name: tbs_colors | ||
adybbroe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
ch10_tbs_colors: | ||
compositor: !!python/name:satpy.composites.SingleBandCompositor | ||
prerequisites: | ||
- name: '10' | ||
standard_name: tbs_colors |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
enhancements: | ||
|
||
mw183_humidity_surface: | ||
standard_name: mw183_humidity_surface | ||
operations: | ||
- name: inverse | ||
method: !!python/name:satpy.enhancements.invert | ||
args: | ||
- [true, true, true] | ||
- name: stretch | ||
method: !!python/name:satpy.enhancements.stretch | ||
kwargs: {stretch: linear} | ||
- name: gamma | ||
method: !!python/name:satpy.enhancements.gamma | ||
kwargs: {gamma: 1.2} | ||
|
||
mw325_humidity: | ||
standard_name: mw325_humidity | ||
operations: | ||
- name: inverse | ||
method: !!python/name:satpy.enhancements.invert | ||
args: | ||
- [true, true, true] | ||
- name: stretch | ||
method: !!python/name:satpy.enhancements.stretch | ||
kwargs: {stretch: linear} | ||
- name: gamma | ||
method: !!python/name:satpy.enhancements.gamma | ||
kwargs: {gamma: 1.2} | ||
|
||
mw325_humidity_surface: | ||
standard_name: mw325_humidity_surface | ||
operations: | ||
- name: inverse | ||
method: !!python/name:satpy.enhancements.invert | ||
args: | ||
- [true, true, true] | ||
- name: stretch | ||
method: !!python/name:satpy.enhancements.stretch | ||
kwargs: {stretch: linear} | ||
- name: gamma | ||
method: !!python/name:satpy.enhancements.gamma | ||
kwargs: {gamma: 1.2} | ||
adybbroe marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a microwave instrument right? Do we need to define a "base" sensor type for "microwave" making this
sensor_name: microwave/mwr
? Or does this work as-is and we won't worry about a shared set of "microwave" composites? If this isn't microwave, then this should probably besensor_name: visir/mwr
, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. I think it sounds right to have a "microwave" group here. I was, however, not sure how this works. But I try add it now.... Just need to do some system, testing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay I believe.