Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'Invalid window id ...' error when restoring a session saved with an invisible Scratch Window (#430) #431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tadashi-aikawa
Copy link

@tadashi-aikawa tadashi-aikawa commented Jan 5, 2025

📃 Summary

Please see #430

closes #430

📸 Preview

none

@shortcuts
Copy link
Owner

Thanks, the changes looks great I've been using it for a few hours and did not noticed unexpected behaviors.

Do you have a way to consistently reproduce the error you've described in #430? It could be great to add a test case in https://github.com/shortcuts/no-neck-pain.nvim/blob/main/tests/test_colors.lua

@tadashi-aikawa
Copy link
Author

@shortcuts
Thank you for confirming!

The issue can be reproduced by following the steps to reproduce and running the specified commands. However, whether the scratch window becomes hidden may depend on the terminal environment (e.g., resolution, font size, etc.). In my case, it was reproduced in a Full HD full-screen display.

@shortcuts
Copy link
Owner

I've added f34e4dc to assert the changes, however I'm not able to make it fail on main so far, I'll take an other look tomorrow!

@tadashi-aikawa
Copy link
Author

@shortcuts
I have set width = 140, but I suspect the test code is set to width = 50. If that's the case, the scratch window might appear, which could explain why the issue is not reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: There are cases where the error 'Invalid window id 1001' occurs when restoring a saved session.
2 participants