-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Closes #2835) Test reverting to 22.04 for tests #2836
Conversation
@arporter Small fix to the GHA to ensure we can still support 3.7. Ready to review. I've added an issue to revert this later as well. |
Thanks very much for doing this and top marks for adding the TODO! Please could you do the same trick for the link-checking action as that too is failing with an error that looks like it's caused by using a more recent Ubuntu. Alternatively, maybe there's a better fix? There may be a new release of the linkcheck action? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2836 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 359 359
Lines 50258 50258
=======================================
Hits 50202 50202
Misses 56 56 ☔ View full report in Codecov by Sentry. |
@arporter You were right, same issue with linkspector. I've added a separate TODO (2838) for linkspector, and link to an issue open on linkspector that other people have posted. Edit: Their latest release claims to havse fixed the issue but doesn't seem to for us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for fixing this Aidan.
Changes are confined to GHA yml files and are marked with TODOs. No need to re-run integration tests.
Will proceed to merge.
Tests seem to be failing with 3.7 now, testing if reverting to ubuntu 22.04 fixes this for now.