Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Closes #2835) Test reverting to 22.04 for tests #2836

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

LonelyCat124
Copy link
Collaborator

Tests seem to be failing with 3.7 now, testing if reverting to ubuntu 22.04 fixes this for now.

@LonelyCat124
Copy link
Collaborator Author

@arporter Small fix to the GHA to ensure we can still support 3.7. Ready to review. I've added an issue to revert this later as well.

@arporter
Copy link
Member

arporter commented Jan 7, 2025

Thanks very much for doing this and top marks for adding the TODO! Please could you do the same trick for the link-checking action as that too is failing with an error that looks like it's caused by using a more recent Ubuntu. Alternatively, maybe there's a better fix? There may be a new release of the linkcheck action?

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (d6dc2bd) to head (398c1a3).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2836   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         359      359           
  Lines       50258    50258           
=======================================
  Hits        50202    50202           
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LonelyCat124
Copy link
Collaborator Author

LonelyCat124 commented Jan 7, 2025

@arporter You were right, same issue with linkspector. I've added a separate TODO (2838) for linkspector, and link to an issue open on linkspector that other people have posted.

Edit: Their latest release claims to havse fixed the issue but doesn't seem to for us.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for fixing this Aidan.
Changes are confined to GHA yml files and are marked with TODOs. No need to re-run integration tests.
Will proceed to merge.

@arporter arporter merged commit 9fe3a1d into master Jan 7, 2025
11 checks passed
@arporter arporter deleted the ubuntu_test_fix branch January 7, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants