Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Civo, a managed Kubernetes service #296

Merged
merged 14 commits into from
Sep 22, 2023
Merged

Add support for Civo, a managed Kubernetes service #296

merged 14 commits into from
Sep 22, 2023

Conversation

itsCheithanya
Copy link
Contributor

Overview

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

Install Civo CLI
https://www.civo.com/docs/overview/civo-cli
Test the plugin by running
op plugin init civo
civo region ls
image

Changelog

@arunsathiya arunsathiya mentioned this pull request Jun 16, 2023
Closed
4 tasks
@arunsathiya arunsathiya changed the title civo plugin Add support for Civo, a managed Kubernetes service Jun 16, 2023
@arunsathiya arunsathiya added the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Jun 16, 2023
@arunsathiya arunsathiya mentioned this pull request Jun 23, 2023
Closed
4 tasks
@arunsathiya
Copy link
Contributor

As noted on the other comment, we'd like to see the "Overview" section of the PR description filled out.

@arunsathiya arunsathiya mentioned this pull request Jun 24, 2023
Closed
4 tasks
hculea
hculea reviewed Jun 24, 2023
View reviewed changes
Copy link
Member

@hculea hculea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Left a few suggestions and a question.

plugins/civo/api_key.go Outdated Show resolved Hide resolved
plugins/civo/api_key.go Outdated Show resolved Hide resolved
plugins/civo/api_key.go Outdated Show resolved Hide resolved
plugins/civo/api_key.go Outdated Show resolved Hide resolved
@itsCheithanya
Copy link
Contributor Author

@arunsathiya @hculea you can review it now

@hculea
Copy link
Member

hculea commented Jun 26, 2023

@itsCheithanya I see there is a another contribution for the same plugin: #312 authored by @siddhikhapare.

To deduplicate some of the remaining work and help move this forward faster, I'd love if you two could collaborate to get this to the finish line 😄

Regardless of which PR you will choose to proceed with, we will be counting this contribution for both of you for the hackathon.

Please let me know if that is okay with you and whether I could help you two connect, on Discord or the 1Password Developer Workspace on Slack! Let's go 🚀

@itsCheithanya
Copy link
Contributor Author

itsCheithanya commented Jun 26, 2023 •
edited
Loading

@itsCheithanya I see there is a another contribution for the same plugin: #312 authored by @siddhikhapare.

To deduplicate some of the remaining work and help move this forward faster, I'd love if you two could collaborate to get this to the finish line smile

Regardless of which PR you will choose to proceed with, we will be counting this contribution for both of you for the hackathon.

Please let me know if that is okay with you and whether I could help you two connect, on Discord or the 1Password Developer Workspace on Slack! Let's go rocket

Hi @hculea , thank you for reaching out. It would great to collaborate with @siddhikhapare and add the missing parts to avoid duplication I wanted to inform you that @AndyTitu and I are already working on the plugin to bring it to completion. Therefore, it would be great if we could use my pull request for further development since contribution for both of us will be counted for the hackathon.

@AndyTitu
Copy link
Contributor

Hi @hculea , thank you for reaching out. It would great to collaborate with @siddhikhapare and add the missing parts to avoid duplication I wanted to inform you that @AndyTitu and I are already working on the plugin to bring it to completion. Therefore, it would be great if we could use my pull request for further development since contribution for both of us will be counted for the hackathon.

It's fine with me but we'll also have to confirm with @siddhikhapare that it's okay to close their PR as duplicate and for you to focus your efforts together on this PR

@siddhikhapare
Copy link
Contributor

@AndyTitu @hculea @itsCheithanya I closed my PR. I'm looking forward to working together.

@AndyTitu AndyTitu added the hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th label Jun 26, 2023
hculea
hculea reviewed Jun 27, 2023
View reviewed changes
plugins/civo/api_key.go Outdated Show resolved Hide resolved
plugins/civo/api_key.go Outdated Show resolved Hide resolved
plugins/civo/api_key.go Outdated Show resolved Hide resolved
plugins/civo/api_key.go Outdated Show resolved Hide resolved
plugins/civo/api_key.go Outdated Show resolved Hide resolved
@accraw accraw removed the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Jun 28, 2023
@accraw accraw added the in-progress this PR is being worked on/comments are in the process of being addressed by the contributor label Jun 28, 2023
@arunsathiya arunsathiya mentioned this pull request Jun 28, 2023
Closed
5 tasks
@siddhikhapare
Copy link
Contributor

@hculea @AndyTitu @arunsathiya Done

@hculea hculea requested review from AndyTitu and hculea and removed request for accraw, arunsathiya and AndyTitu July 5, 2023 07:45
hculea
hculea approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@hculea hculea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! @arunsathiya can I ask you to take it for a functional spin?

plugins/civo/api_key.go Outdated Show resolved Hide resolved
plugins/civo/api_key.go Outdated Show resolved Hide resolved
@hculea hculea requested a review from arunsathiya July 5, 2023 10:06
arunsathiya
arunsathiya suggested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@arunsathiya arunsathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission, @itsCheithanya and @siddhikhapare. I am unclear on what's happening with CIVO_API_KEY and CIVO_TOKEN though, and also on what's happening in the config file importer. Could you address those parts and other nits throughout the PR?

We'll be around if you have any questions along the way.

plugins/civo/api_key.go Outdated Show resolved Hide resolved
plugins/civo/api_key.go Outdated Show resolved Hide resolved
plugins/civo/api_key.go Show resolved Hide resolved
plugins/civo/api_key.go Outdated Show resolved Hide resolved
plugins/civo/api_key.go Outdated Show resolved Hide resolved
@arunsathiya arunsathiya self-requested a review July 6, 2023 21:14
@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member and removed in-progress this PR is being worked on/comments are in the process of being addressed by the contributor labels Jul 24, 2023
AndyTitu
AndyTitu approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddhikhapare this PR seems ready, we just have a few very minor suggestions, but I am approving this. If you could address the last suggestions, we could merge this PR. Thanks!

@AndyTitu AndyTitu added waiting-on-sec-review and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Aug 30, 2023
SimonBarendse
SimonBarendse approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the contribution, @itsCheithanya! ❤️

@SimonBarendse SimonBarendse merged commit 331a885 into 1Password:main Sep 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddhikhapare siddhikhapare siddhikhapare left review comments

@hculea hculea hculea approved these changes

@AndyTitu AndyTitu AndyTitu approved these changes

@SimonBarendse SimonBarendse SimonBarendse approved these changes

@arunsathiya arunsathiya Awaiting requested review from arunsathiya

Assignees

@siddhikhapare siddhikhapare

@itsCheithanya itsCheithanya

Labels
hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th waiting-on-sec-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@itsCheithanya @arunsathiya @hculea @AndyTitu @siddhikhapare @SimonBarendse @accraw