Correcting errors #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added slicing to the iterative models
…`, `str` fixed the `PlayerBulkRequest._async_from_clan` class method so that it accepts `Clan`, `MemberList`, `str` as arguments for the class initialisation
added a ToDo-list for planned code implementations
added `__version__` to the `pyclasher` `__init__.py` file
added a requirements file to install pytest and other dependencies
added `ClanWarResult.NONE` in the `Enums.py` file because the war state of CWL clan wars is None sometimes
rewrite of the async clan tests to use more features of pytest to make the code simpler
it will become depreciated, use `Player.best_builder_base_trophies` instead
it will become depreciated, use `Player.builder_base_trophies` instead
…elsRequest` __init__ method
`super()` does not work for multiple inheritance so it got split up
now it is in the right dir and works with the test fixtures
included SuperCell fan content policy disclaimer in the README.md file
the pull_request.yml workflow did not use the requirements_tests.txt file to install the needed requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.