Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting errors #24

Merged
merged 26 commits into from
Aug 19, 2023
Merged

Correcting errors #24

merged 26 commits into from
Aug 19, 2023

Commits on Jul 28, 2023

  1. improved iterative models 

    added slicing to the iterative models
    @201st-Luka
    201st-Luka committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3cc2456 View commit details
    Browse the repository at this point in the history

  2. created build.sh

    @201st-Luka
    201st-Luka committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    e52b211 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. fix: PlayerBulkRequest._async_from_clan accepts Clan, `MemberList… 

    …`, `str`

fixed the `PlayerBulkRequest._async_from_clan` class method so that it accepts `Clan`, `MemberList`, `str` as arguments for the class initialisation
    @201st-Luka
    201st-Luka committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    584bb0b View commit details
    Browse the repository at this point in the history

  2. style: line break after 120 characters in client.py

    @201st-Luka
    201st-Luka committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    47e57db View commit details
    Browse the repository at this point in the history

  3. fix: correct type hinting for ApiCodes.from_exception

    @201st-Luka
    201st-Luka committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    367ddf7 View commit details
    Browse the repository at this point in the history

  4. feat: added a ToDo-list in the README.md 

    added a ToDo-list for planned code implementations
    @201st-Luka
    201st-Luka committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    7901fd0 View commit details
    Browse the repository at this point in the history

  5. feat: added __version to pyclasher 

    added `__version__` to the `pyclasher` `__init__.py` file
    @201st-Luka
    201st-Luka committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    3768396 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2023

  1. feat: added requirements_tests.txt 

    added a requirements file to install pytest and other dependencies
    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    948fe78 View commit details
    Browse the repository at this point in the history

  2. fix: added ClanWarResult.NONE in the Enums.py file 

    added `ClanWarResult.NONE` in the `Enums.py` file because the war state of CWL clan wars is None sometimes
    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    46214d8 View commit details
    Browse the repository at this point in the history

  3. tests: rewrite and improvement 

    rewrite of the async clan tests to use more features of pytest to make the code simpler
    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    5ae66e3 View commit details
    Browse the repository at this point in the history

  4. fix!: removed Player.best_versus_trophies 

    it will become depreciated, use `Player.best_builder_base_trophies` instead
    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    6cc970b View commit details
    Browse the repository at this point in the history

  5. fix!: removed Player.versus_trophies 

    it will become depreciated, use `Player.builder_base_trophies` instead
    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    7fa449a View commit details
    Browse the repository at this point in the history

  6. refactor: used double equality instead of 2 lines

    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    cbf9ad8 View commit details
    Browse the repository at this point in the history

  7. fix: Player.league can be MISSING

    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    d4e9238 View commit details
    Browse the repository at this point in the history

  8. test: added PlayerRequestTest

    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    c6f3dd4 View commit details
    Browse the repository at this point in the history

  9. fix: corrected wrong type hint for ClanLabelsRequest and `PlayerLab… 

    …elsRequest` __init__ method
    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    40d815c View commit details
    Browse the repository at this point in the history

  10. test: implemented label tests

    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    52d2149 View commit details
    Browse the repository at this point in the history

  11. fix: BaseModel:__init__ default data argument is None

    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    8ed0159 View commit details
    Browse the repository at this point in the history

  12. fix: initializing GoldPassRequest fix 

    `super()` does not work for multiple inheritance so it got split up
    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    5f331f0 View commit details
    Browse the repository at this point in the history

  13. test: GoldPassRequest test

    @201st-Luka
    201st-Luka committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    c5c54c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. test: LocationsRequest test

    @201st-Luka
    201st-Luka committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    b608720 View commit details
    Browse the repository at this point in the history

  2. fix: test_locations.py file was not in the right directory 

    now it is in the right dir and works with the test fixtures
    @201st-Luka
    201st-Luka committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    17853f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. feat: updated README.md 

    included SuperCell fan content policy disclaimer in the README.md file
    @201st-Luka
    201st-Luka committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    10dfd2b View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. fix: corrected test workflow 

    the pull_request.yml workflow did not use the requirements_tests.txt file to install the needed requirements
    @201st-Luka
    201st-Luka committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    834c5b5 View commit details
    Browse the repository at this point in the history

  2. fix: solved import error

    @201st-Luka
    201st-Luka committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    f84e331 View commit details
    Browse the repository at this point in the history

  3. fix: solved import error in test_client.py

    @201st-Luka
    201st-Luka committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    fcf0641 View commit details
    Browse the repository at this point in the history