-
Notifications
You must be signed in to change notification settings - Fork 87
feature: Helm chart for Kubernetes deployment #1124
Conversation
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
I have read the CLA Document and I hereby sign the CLA |
recheck |
@tolbrino and @ausias-armesto thank you for your contribution.
This is not something that we need for the project. My recommendation is to fork the repository and change it according to your needs. At the moment we won't specify on how the service should be deployed and the respective resources (that is up to each team using it). This applies to the suggested kubernetes configuration. |
Thanks for the feedback. We are already working with our own forks, but that does not help out the Safe community as a whole since discovery of such additional changes is hard. I understand you might not want to add these files into each repository. How about creating a new repository called |
We try to address the community needs including feature-discovery. However a discussion about those needs is also required. The introduction of this tool and respective deployment files assumes that this how the project should be deployed and these tools should be used. We do not make any assumptions on how the deployment should work in this repo and we give that choice to the developers who want to run our services themselves. We do provide a Docker image to make it easier to deploy but even then we do not assume that the image itself should be used (e.g. a developer/team might want to use a competing solution to Docker).
If the suggestion is for it to live under the Also, there was no discussion on why this change is necessary for the project and an evaluation on the community support behind it. Adding Helm to the repository assumes that Helm is the desired solution that we want for the community and so far that discussion did not take place. Since this repository mostly deals with the business logic for client-side rendering, the respective deployment of such service should in this case be considered on a separate repo (as you suggested). |
Closing. Moved helm chart into https://github.com/hoprnet/safe-charts |
Make sure these boxes are checked! π¦β
rustfmt
installedcargo +nightly fmt
on the code base before submittingWhat was wrong? πΎ
The repository was lacking a Helm chart for Kubernetes deployment.
How was it fixed? π―
The Helm chart was added at
charts/safe-client-gateway
, a location adhering to Helm best-practises. The helper script atscripts/build-and-publish-helm-chart.sh
can be used for releasing new versions of the Helm chart. Documentation of the chart is atcharts/safe-client-gateway
.This chart is already used successfully to run the Safe infrastructure in Kubernetes.
Sibling PRs