Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Helm chart for Kubernetes deployment #911

Closed
wants to merge 3 commits into from

Conversation

tolbrino
Copy link

@tolbrino tolbrino commented Jul 31, 2023

What was wrong? 👾

The repository was lacking a Helm chart for Kubernetes deployment.

How was it fixed? 🎯

The Helm chart was added at charts/safe-config-service, a location adhering to Helm best-practises. The helper script at scripts/build-and-publish-helm-chart.sh can be used for releasing new versions of the Helm chart. Documentation of the chart is at charts/safe-config-service.

This chart is already used successfully to run the Safe infrastructure in Kubernetes.

Sibling PRs

@tolbrino tolbrino requested a review from a team as a code owner July 31, 2023 09:08
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@tolbrino
@ausias-armesto
You can retrigger this bot by commenting recheck in this Pull Request

@tolbrino
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

recheck

@tolbrino
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@tolbrino
Copy link
Author

recheck

@fmrsabino
Copy link
Contributor

@tolbrino thank you for your contribution.

The repository was lacking a Helm chart for Kubernetes deployment.

This is not something that we need for the project. My recommendation is to fork the repository and change it according to your needs.

At the moment we won't specify on how the service should be deployed and the respective resources (that is up to each team using it). This applies to the suggested kubernetes configuration.

@tolbrino
Copy link
Author

tolbrino commented Aug 1, 2023

Closing. Moved helm chart into https://github.com/hoprnet/safe-charts

@tolbrino tolbrino closed this Aug 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants