-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to clean up each test dir #146
Conversation
is this still WIP? |
Thanks @zingale. On my end, I was just thinking that we might want to change the name of the user-facing option. Right now it's |
I like |
I pushed the change, ready to go on my end. |
Ok, this doesn't clean up plotfiles since the regression testing framework compresses them before the cleanup code runs. It also doesn't clean up executables (which can be hundreds of MBs):
I also have @zingale Do you have a recommendation on how to get it to delete the compressed plotfiles? Is there an option to delete the executable? |
Cc: @ax3l @RemiLehe
Add option to clean up each test directory right after the test ran and passed (not at the end of the whole test suite).
As is, the option
rm_testdir
(probably to be renamed, see to-do list below) currently removes all subdirectories within a given test directory, which should catch all output data regardless of the format and/or naming convention, but leaves individual files untouched (code currently commented out).We implemented this quickly to test a bug fix in WarpX (ECP-WarpX/WarpX#5120) and it might be that a combination of existing options (e.g.,
purge_output
,do_temp_run
, etc.) might accomplish the same result, if properly used.Need to sync with other contributors for further development.
Also note that, on the WarpX end, this will become irrelevant once we transition to CTest (ECP-WarpX/WarpX#5068).
To-do:
main
at allrm_testdir
with more accurate name