Added nix support #100
Added nix support #100
Conversation
| @@ -0,0 +1,56 @@ | |||
| # An example package with dependencies defined via pyproject.toml | |||
There was a problem hiding this comment.
This seems to be a left over generic statement from a template or generator and should be adjusted
| pyproject = lib.importTOML (config.mkDerivation.src + /pyproject.toml); | ||
| in { | ||
| imports = [ | ||
| dream2nix.modules.dream2nix.pip |
There was a problem hiding this comment.
dream2nix is according to their own webpages still heavily in development and not yet ready for productive use. Hence, I would want to avoid using it in ARTIST without further stabilization (c.f. https://github.com/nix-community/dream2nix)
| "flake": false, | ||
| "locked": { | ||
| "lastModified": 1696426674, | ||
| "narHash": "sha256-kvjfFW7WAETZlt09AgDn1MrtKzP7t90Vf7vypd3OL1U=", |
There was a problem hiding this comment.
Since I have never worked with nix(-flake) myself, I do not know what these hashes refer to and whether they are valid or a security concern. How can I verify the integrity to which these resources are pointing?
| @@ -0,0 +1,69 @@ | |||
| { | |||
| # This example flake.nix is pretty generic and the same for all | |||
There was a problem hiding this comment.
This is again a generic header from some template or generator - adjustments for ARTIST would be necessary
| "is_direct": false, | ||
| "sha256": "1c99d261bd2d5f6b59325c92c73df481e05e57f19837bdca8413b9eac4bd8028", | ||
| "type": "url", | ||
| "url": "https://files.pythonhosted.org/packages/e0/25/dd5c0f6ac1311e9b40f4af06c78efde0f3b5cbf02502f8ef9501294c425b/MarkupSafe-3.0.2-cp312-cp312-manylinux_2_17_aarch64.manylinux2014_aarch64.whl", |
There was a problem hiding this comment.
Again, since we have not worked yet with nix, how are these URLs adjusted for the other platforms (e.g. darwin) that have been declared in the other files, while it is here hardcoded to be aarch64?
|
Pull request seems stale @faezs. Are you intending to bring it up-to-date or answer the questions? |
Description
Added a nix flake for reproducible builds and easy devShells. I'm sure this is not high on your priority list but happy to fix any issues with the support if they ever come up.
Fixes # (issue)
N/A
Type of change
Checklist: