Semret - Personal Portfolio - Edges

[snicodimos]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	Parent and child relations in my html. I didn't fully resolve it as I didn't know how to switch it around without messing the follow of the content.
Why is it important to consider and use semantic HTML?	For better readability, and organization of the content.
How did you decide to structure your CSS?	I like the follow of the content and when I decided what to include on my site I decided the structure of it.
What was the most challenging piece of this assignment?	Understanding the validation area and also making the timeline of projects.
Describe one area that you gained more clarity on when completing this assignment	making grid and flexbox.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

[droberts-sea]

Personal Portfolio Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	I think you could do a better job of breaking work up into small commits. When I see a message like "final 4 pages", that tells me you forgot to commit.
Answered comprehension questions	yes - you might want to look up "follow" vs "flow"
Page fully loads	yes
No broken links (regular or images)	yes
Includes at least 4 pages and styling	yes
HTML
Uses the high-level tags for organization: header, footer, main	could be better
Appropriately using semantic tags: section, article, etc.	yes
All images include alternate text	yes
CSS
Using class and ID names in style declarations	yes
Style declarations are DRY	Many styles (like the banner and the nav buttons) are common to all your pages, and the CSS for these are repeated. A good approach here is to put all common styles in a separate .css file, and have each .html file link against both the common and page-specific stylesheets.
Overall	Good work overall! I see some room for improvement around high-level organization, both of your HTML and your CSS. However, you were able to build an attractive, functional website, and it's clear to me that the learning goals for this assignment were met. Keep up the hard work!

[droberts-sea]

Since it's used for navigation, this should probably be a <nav>, not a <section>.

[droberts-sea]

You should pick more meaningful class names than sect1 or sect2. Think of them the same way you would variable names.

[droberts-sea]

You should break line 10 across multiple lines.

[droberts-sea]

This was a cool effect - nice work getting this figured out!