Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Move from npm to pnpm #257

Merged
merged 3 commits into from
Aug 8, 2023
Merged

🔧 Move from npm to pnpm #257

merged 3 commits into from
Aug 8, 2023

Conversation

joao-m-santos
Copy link
Contributor

Closes #200

📝 Description

  • Removed nx and nx config files
  • Added config for Storybook in Vue 2 and Vue 3
  • Added pnpm workspace config and scripts
  • Upgraded to Storybook 7 (still missing Story changes, will be done in a future PR)

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

📝 Additional Information

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@joao-m-santos joao-m-santos self-assigned this Aug 8, 2023
@joao-m-santos joao-m-santos requested a review from a team as a code owner August 8, 2023 12:36
@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit 2c92055
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/64d243ad32519600084fb21c
😎 Deploy Preview https://deploy-preview-257--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joao-m-santos joao-m-santos changed the title 🔧 Move from npm to pnpm Draft: 🔧 Move from npm to pnpm Aug 8, 2023
@joao-m-santos joao-m-santos changed the title Draft: 🔧 Move from npm to pnpm 🔧 Move from npm to pnpm Aug 8, 2023
packages/vue2/package.json Show resolved Hide resolved
@joao-m-santos joao-m-santos merged commit 1270153 into main Aug 8, 2023
8 checks passed
@joao-m-santos joao-m-santos deleted the 200-move-to-pnpm-updated branch September 5, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate a way to develop and test components on both Vue versions
2 participants