feat: enable form generation and validation using json schema #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helen-m-lin
commented
Nov 26, 2024
| @@ -212,3 +224,40 @@ def from_airflow_task_instance( | |||
| duration=airflow_task_instance.duration, | |||
| comment=airflow_task_instance.note, | |||
| ) | |||
|
|
|||
|
|
|||
| class ModalityConfigsForm(ModalityConfigs): | |||
There was a problem hiding this comment.
It might be best for these wrapper models to go in aind-data-transfer-models?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #107
This PR introduces 2 new endpoints to enable form generation and validation using json schema:
/api/v1/models/{model_name}/schema/api/v1/models/{model_name}/validateA new on-prem service (React app) will generate and validate the form using the above endpoints. The new service can also post the job request accordingly.
NOTE: A few wrappers around
aind-data-transfer-modelsare required for form generation. These form models: