Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: config files inside .GitHub folder #252

Merged
merged 13 commits into from
Dec 25, 2022
Merged

feat: config files inside .GitHub folder #252

merged 13 commits into from
Dec 25, 2022

Conversation

LuisHenri
Copy link
Contributor

Description

Close #249

Firstly search for .templatesyncignore and .templateversionrc inside .github folder. If not found, inside the root.

LuisHenri and others added 3 commits December 13, 2022 23:37
@LuisHenri
feat: let .templatesyncignore and .templatesyncversion be inside .github
ae74fd9 
Signed-off-by: Luís Henrique A. Schünemann <44511825+LuisHenri@users.noreply.github.com>
@LuisHenri
refactor(sync-template): use .templateversionrc from root if found
d117c7f 
Otherwise, if it is not present or inside .github, use it as if inside .github
@LuisHenri
docs(readme): add docs regarding .templatesyncignore being inside .gi…
38108c6 
…thub folder
AndreasAugustin
AndreasAugustin reviewed Dec 14, 2022
View reviewed changes
Copy link
Owner

@AndreasAugustin AndreasAugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @LuisHenri for the PR! Just some discussion would be nice :)

src/sync_template.sh Outdated Show resolved Hide resolved
src/sync_template.sh Outdated Show resolved Hide resolved
src/sync_template.sh Outdated Show resolved Hide resolved
@LuisHenri
Copy link
Contributor Author

Thank you very much @LuisHenri for the PR! Just some discussion would be nice :)

Thank you! I'm all ears to discuss it. I'll take a look on your feedback when I have some time. :)

AndreasAugustin
AndreasAugustin requested changes Dec 18, 2022
View reviewed changes
Copy link
Owner

@AndreasAugustin AndreasAugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LuisHenri thanks a lot for the changes!
As mentioned and discussed in #249 let's prefer .github/ folder before the repo root.
Would be nice if you could do those changes 🚀

Another question. Would it be also possible for you to update docs/ARCHITECTURE.md would be nice if you find time (if not, I can also do it 👍 ). It is a small change in the mermaid diagram

src/sync_template.sh Outdated Show resolved Hide resolved
LuisHenri and others added 2 commits December 24, 2022 13:00
@LuisHenri
docs(readme): fix conflict
b544529
@LuisHenri
Merge branch 'main' into feat/config-files-inside-.github
70a2ef1 
Signed-off-by: Luís Henrique A. Schünemann <44511825+LuisHenri@users.noreply.github.com>
AndreasAugustin
AndreasAugustin requested changes Dec 25, 2022
View reviewed changes
Copy link
Owner

@AndreasAugustin AndreasAugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. A small change in the documentation would be nice.

docs/ARCHITECTURE.md Outdated Show resolved Hide resolved
@AndreasAugustin AndreasAugustin added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 25, 2022
@allcontributors allcontributors bot mentioned this pull request Dec 25, 2022
Merged
@allcontributors
Copy link
Contributor

@AndreasAugustin

I've put up a pull request to add @LuisHenri! 🎉

@AndreasAugustin
Copy link
Owner

@all-contributors
please add @LuisHenri for code and doc

@allcontributors allcontributors bot mentioned this pull request Dec 25, 2022
Merged
@allcontributors
Copy link
Contributor

@AndreasAugustin

I've put up a pull request to add @LuisHenri! 🎉

@AndreasAugustin AndreasAugustin merged commit 8aa35f1 into AndreasAugustin:main Dec 25, 2022
@LuisHenri LuisHenri mentioned this pull request Dec 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasAugustin AndreasAugustin AndreasAugustin approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
actions-template-sync
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let .templatesyncignore be inside .github folder
2 participants
@LuisHenri @AndreasAugustin