Add twist-stamper node so nav2 example works with humble #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
srmainwaring
force-pushed
the
prs/pr-ros2-navigation-with-twist-stamper
branch
from
4c2b756
to
1fb59d0
Compare
Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
srmainwaring
force-pushed
the
prs/pr-ros2-navigation-with-twist-stamper
branch
from
1fb59d0
to
ef5357e
Compare
|
Every thing works fine, |
Ryanf55
reviewed
Oct 15, 2024
Ryanf55
approved these changes
Oct 29, 2024
|
Thanks @ryan, I'll merge once the issue with the failing test is resolved. Ah, that's an upstream issue with ardupilot_gazebo - missing the gstreamer deps in the cmake. Let me get onto that. |
pedro-fuoco
reviewed
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main addition is to add a twist-stamper node to allow the nav2 example to work with ROS 2 Humble.
See #11 (comment) for details.
Other changes include:
SDF_PATHenv variable is set in launch file to allow robot state publisher to resolve the model (and so TF).Dependences