Prevent crashing for "Unsupported image type" error #2317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I hope this message finds all of you well. I have encountered an issue where the "Unsupported image type" error was being thrown in the
setSource
function of the canvas library. After investigating, I found out that this error was causing unexpected crashes in certain scenarios.In my case these certain scenarios were pretty interesting. I have not been interacting directly with the library, randomly, my code crashed because of this error. My motivation to fix this error is a more robust code base, because in my case, my application should not crash in no matter what case.
To address this issue, I have added a try-catch block to the
setSource
function in the lib/image.js file. This should prevent unexpected crashes hopefully and ensures that the application can gracefully handle cases where the image type is not supported.I have added the following code to address this issue.
I will already say thank you for reviewing my pull requests! let me know if it's possible to apply these changes.
sincerely Rosie!