Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crashing for "Unsupported image type" error #2317

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent crashing for "Unsupported image type" error #2317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5909dd7
Update image.js
klover-rs Dec 2, 2023
36ed665
Update CHANGELOG.md
klover-rs Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ project adheres to [Semantic Versioning](http://semver.org/).
==================
### Changed
### Added

- added a try and catch block in lib/image.js in the setSource function, to prevent unexpected crashing, if an 'Unsupported image type' is provided.

### Fixed

3.0.0
Expand Down
9 changes: 7 additions & 2 deletions lib/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ function getSource (img) {
}

function setSource (img, src, origSrc) {
SetSource.call(img, src)
img._originalSource = origSrc
try {
SetSource.call(img, src)
img._originalSource = origSrc
} catch (err) {
img._originalSource = null
throw err
}
}