Actually bump minimum Parse.ly version to 3.15 in parsely.yml workflow #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6071 +/- ##
=============================================
+ Coverage 30.53% 30.55% +0.01%
Complexity 4812 4812
=============================================
Files 289 289
Lines 21200 21188 -12
=============================================
Hits 6474 6474
+ Misses 14726 14714 -12 ☔ View full report in Codecov by Sentry. |
sjinks
force-pushed
the
update/parsely-matric
branch
from
278e4dd to
847b958
Compare
|
sjinks
reviewed
Dec 24, 2024
| 'should_track_logged_in_users' => is_latest_version() ? false : true, | ||
| 'should_track_logged_in_users' => false, |
There was a problem hiding this comment.
This has changed since 3.5; track_authenticated_users was true in 3.5 and changed to false later.
sjinks
reviewed
Dec 24, 2024
Comment on lines
-342
to
+343
| 'site_id' => is_latest_version() ? 'site_id_value' : '', | ||
| 'have_api_secret' => is_latest_version() ? true : false, | ||
| 'site_id' => 'site_id_value', | ||
| 'have_api_secret' => true, |
There was a problem hiding this comment.
We set site_id and api_secret earlier in the code.
sjinks
reviewed
Dec 24, 2024
| ) ); | ||
| ), $configs ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test
CI should pass