Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually bump minimum Parse.ly version to 3.15 in parsely.yml workflow #6071

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
+8 −8
Open

Actually bump minimum Parse.ly version to 3.15 in parsely.yml workflow #6071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69a54fe
Actually bump minimum Parse.ly version to 3.15 in parsely.yml workflow
rinatkhaziev Dec 24, 2024
828011d
`track_authenticated_users` is `false` by default
sjinks Dec 24, 2024
847b958
fix: the order is `expected, actual`
sjinks Dec 24, 2024
b37aba4
fix: tests
sjinks Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/parsely.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
matrix:
config:
# Oldest version of the parsely plugin
- { wp: latest, parsely: '3.5', mode: 'filter_enabled', php: '8.1' }
- { wp: latest, parsely: '3.5', mode: 'filter_disabled', php: '8.1' }
- { wp: latest, parsely: '3.15', mode: 'filter_enabled', php: '8.1' }
- { wp: latest, parsely: '3.15', mode: 'filter_disabled', php: '8.1' }

# Latest version of the parsely plugin
- { wp: latest, mode: 'filter_enabled', php: '8.1' }
Expand Down
12 changes: 6 additions & 6 deletions tests/parsely/test-mu-parsely-integration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ public function test_default_parsely_configs() {
'have_api_secret' => false,
'is_javascript_disabled' => false,
'is_autotracking_disabled' => false,
'should_track_logged_in_users' => is_latest_version() ? false : true,
'should_track_logged_in_users' => false,
'tracked_post_types' => array(
array(
'name' => 'post',
Expand Down Expand Up @@ -337,13 +337,13 @@ public function test_parsely_configs_for_managed_mode() {
$configs = Parsely_Loader_Info::get_configs();

// Assert.
$this->assertEquals( $configs, array(
$this->assertEquals( array(
'is_pinned_version' => has_filter( 'wpvip_parsely_version' ),
'site_id' => is_latest_version() ? 'site_id_value' : '',
'have_api_secret' => is_latest_version() ? true : false,
'site_id' => 'site_id_value',
'have_api_secret' => true,
Comment on lines -342 to +343
Copy link
Member

@sjinks sjinks Dec 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set site_id and api_secret earlier in the code.

'is_javascript_disabled' => false,
'is_autotracking_disabled' => false,
'should_track_logged_in_users' => is_latest_version() ? false : true,
'should_track_logged_in_users' => false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has changed since 3.5; track_authenticated_users was true in 3.5 and changed to false later.

'tracked_post_types' => array(
array(
'name' => 'post',
Expand All @@ -358,7 +358,7 @@ public function test_parsely_configs_for_managed_mode() {
'track_type' => 'do-not-track',
),
),
) );
), $configs );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order is expected, actual.

}

public function test_alter_option_use_repeated_metas() {
Expand Down
Loading