Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center: Show a spinner instead of "nothing found" #97181

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented Dec 6, 2024

Fixes: #97170

Proposed Changes

Screen.Recording.2024-12-06.at.17.20.53.mov

Why are these changes being made?

The UX was jarring.

Testing Instructions

  1. Start a chat (with flag enabled = flags=help-center-experience).
  2. Delete Calypso index DB in DevTools.
  3. Refresh the page.
  4. Open the Help Center.
  5. In DevTools > Network, simulate Slow 3G.
  6. Click "History"
  7. A spinner should show.

@alshakero alshakero requested a review from a team as a code owner December 6, 2024 16:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 6, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/show-loading-instead-nothing on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 6, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~24 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-automattic-help-center       +135 B  (+0.0%)      +24 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@agrullon95 agrullon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well. Simple, but great UX improvement!

@escapemanuele escapemanuele merged commit 3336b37 into trunk Dec 9, 2024
13 checks passed
@escapemanuele escapemanuele deleted the fix/show-loading-instead-nothing branch December 9, 2024 10:37
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Center: show "loading" instead of "Nothing found" in chat history window
4 participants